Remove unimplemented static variant functions 'blend' and 'interpolate'…#1626
Merged
dsnopek merged 1 commit intogodotengine:masterfrom Oct 30, 2024
Merged
Conversation
…e'. If a user attempts to call either of these it will introduce a linker error and it may not be immediately clear to them why. Also, variant interpolation can already be accessed via 'UtilityFunctions::lerp', making at least the interpolate function unecessary here.
dsnopek
added
bug
dsnopek
approved these changes
Oct 29, 2024
Collaborator
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks!
I looks like Godot doesn't have these functions on its version of Variant, so I think removing them is the right way to go.
Collaborator
|
Cherry-picked for 4.2 in PR #1694 |
Collaborator
|
Cherry-picked for 4.3 in PR #1695 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user attempts to call either of these it will introduce a linker error and it may not be immediately clear to them why. Also, variant interpolation can already be accessed via 'UtilityFunctions::lerp', making at least the interpolate function unnecessary here.