Sync Quaternion with the version in Godot#1630
Merged
dsnopek merged 1 commit intogodotengine:masterfrom Oct 29, 2024
Merged
Conversation
dsnopek
added
the
enhancement
fire
approved these changes
Oct 28, 2024
Member
fire
left a comment
fire
left a comment
There was a problem hiding this comment.
This resolves the issue because Vector3 Quaternion::get_euler(EulerOrder p_order) const is supplied so that people can decide to use the right euler with the right rotation type (of 6)
AThousandShips
approved these changes
Oct 29, 2024
Collaborator
Author
|
Cherry-picked for 4.2 in PR #1694 |
Collaborator
Author
|
Cherry-picked for 4.3 in PR #1695 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1629
I basically just copied Godot's
quaternion.h/.cppover godot-cpp's, then undid changes where the differences were necessary.