CMake: template_debug as default target when godot-cpp is top level#1728
Merged
dsnopek merged 1 commit intogodotengine:masterfrom Mar 6, 2025
Merged
CMake: template_debug as default target when godot-cpp is top level#1728dsnopek merged 1 commit intogodotengine:masterfrom
dsnopek merged 1 commit intogodotengine:masterfrom
Conversation
dsnopek
approved these changes
Mar 5, 2025
Collaborator
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! This seems to work in my testing
However, I just want to make sure this isn't something you have technical reservations about based on your comments in #1724? But if you're happy with the code added in this PR, I think it's fine to move forward with it
Collaborator
Author
|
@dsnopek no reservations for this fix, we've aleady had two reports from people expecting a default build, so merging it woud be in our best interest. |
People seem to want to build godot-cpp without any arguments, not even specifying a target. We have to detect if we are top level though because it conflicts with being consumed.
dsnopek
added
cmake
topic:buildsystem
Collaborator
|
Cherry-picked for 4.4 in PR #1745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People seem to want to build godot-cpp by itself, without any arguments, not even specifying a target.
So we have to detect if we are top level and make template_debug available for the all target.
This can only happen when we are the top level target, because if we enable template_debug for all when we are part of something larger than its unnecessary compilation.
This adresses #1724 and duplicate #1727