Use temp file and short paths for Android crosscompilation on Windows. #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the original Windows spawn fix when compiling for Android since it wasn't always working and could've lead to "Filename is too long" errors when linking godot-cpp with llvm-ar.
The new approach involves moving the arguments passed to llvm-ar into a temp file (this approach is very common and used widely on other projects using llvm-ar already) in combination with using short path for the toolchain path (this ensures that the path has no whitespaces which would lead to corrupted commands being generated by scons. This is particularly important since the default installation path for the Android SDK is in C:\Program Files (x86) which includes whitespaces.