Fix leaks caused by implicitly-called copy constructors#355
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 4, 2019
Merged
Fix leaks caused by implicitly-called copy constructors#355akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
|
I test this fix is ok and can fix #318, your solution is beautiful, only use a local variable fix ref-count |
Member
|
Thanks! |
Contributor
Author
|
Looks like this still leaks for Array and Dictionary. I forgot to take into account that their default constructors, unlike PoolArrays, allocate a small empty array that is now getting leaked instead of the one in the Variant. I don't know of any way to prevent this default constructor call in C++. Instead of trying more hackish casts, I think I'll just add a safe, clean constructor to Array and Dictionary: |
This was referenced Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Variants were unpacked like this:
The cast implicitly calls the C++ type's copy constructor. (You can find it in the gdb disassembly.) This increases the ref-count twice instead of just once through
godot_variant_as_*. For PoolArrays, it caused an error message on exiting Godot:All of the ref-counted, RAII-managed core types are affected. The fix is to use a local variable and return it instead of casting.