Make the CI build jobs conditional on the static checks' success.#899
Closed
PapyChacal wants to merge 1 commit intogodotengine:masterfrom
Closed
Make the CI build jobs conditional on the static checks' success.#899PapyChacal wants to merge 1 commit intogodotengine:masterfrom
PapyChacal wants to merge 1 commit intogodotengine:masterfrom
Conversation
Calinou
added
the
enhancement
PapyChacal
force-pushed
the
CI-format-conditional
branch
from
c35cc4c to
b657078
Compare
PapyChacal
force-pushed
the
CI-format-conditional
branch
from
b657078 to
39f75e4
Compare
Contributor
Author
|
Used reusable workflow instead, so this just works now. For the engine's main repository, it turns out someone already did the work: godotengine/godot#65232 |
AThousandShips
changed the title
Collaborator
|
@PapyChacal it looks like this feature has been incorporated into the CI, at least that is my experience. That being the case, this PR can be closed? |
Collaborator
|
Yep, I think this was implemented in #1622 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR offers to make heavy build jobs conditional on static checks' success.
Rationale: I realized that when I have a minor style issue on my commit, I often correct it right away and push or push-force it. This triggers the jobs as many times as one pushes; even a push force is not cancelling the overridden commit's CI jobs, leading to a fair amount of wasted CI time.
I'm not sure what the stakes are for the Godot team, be it quotas and/or bills, but I guess it wouldn't hurt to avoid wasting it.
If this is of interest, I can do the same on Godot's side, where it would be more significant.