Closed
Conversation
748ddf2 to
72cb01f
Compare
72cb01f to
65b3d3d
Compare
groud
requested changes
Dec 8, 2022
Member
There was a problem hiding this comment.
We reviewed this PR in the GDextension review meeting. We overall agree with the idea of spliting tests and examples into two different folders. Here are some feedback:
- The
example.cpp/.hfiles in test should probably be renamed totest.cpp/.h. - The example is a bit too complex now, and should limit itself to one property, and a few representative example functions.
Collaborator
|
Superseded by #1101 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testfolder has been renamedexampletestfolder has been created, it contains a simple project which has a GDScript file running asserts on the built extension, then closing the appNow I'm not sure how we should run this in the CI:
As long as Godot 4 is not released, there is frequent breakage on Godot master, so downloading the latest official build seems not viable (but on the other hand it seems the way to go when Godot 4 is released)
On the other hand, building Godot from the master seems overkill, so I'm not sure we want that.
Even if we don't add this test to Godot-CPP's, we should run it in the Godot CI where Godot-CPP is currently build.
PS: I'm not sure I'll have much time to continue work on this, so feel free to modify this PR (or even copy part of it without bothering with crediting me and create your own PR 😄 )