fix: Fix decompressed bundled source use after free#212
Merged
Benjamin-Dobell merged 1 commit intoApr 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused an intermittent failures e.g. https://github.com/godotjs/GodotJS/actions/runs/24649141103/job/72067918791.
I didn't review the history, but judging by how the code is written I suspect the data was not initially compressed, so the static data pointers were valid indefinitely (pointer to read-only load data in the executable). However, since the data is now decompressed, the data's lifetime is tied to lifetime of the
PresetSource. It's stack allocated, so when it goes out of scope it's destroyed. Looks like we'd been getting lucky most of the time and nothing was writing to the now freed address range - but not so in that GHA run. Glad this was caught!