Fix/implement some essential script instance behaviors.#218
Open
Daylily-Zeleen wants to merge 1 commit into
Open
Fix/implement some essential script instance behaviors.#218Daylily-Zeleen wants to merge 1 commit into
Daylily-Zeleen wants to merge 1 commit into
Conversation
1. Fix parsing script class: only detecting doc, property and signal in current class (without base class). 2. Implement essential godot object' virtual functions. 3. Fix `GodotJSScript::has_script_signal`.
Daylily-Zeleen
force-pushed
the
daylily-zeleen/fix_class_info
branch
from
309d3ef to
64cbcb3
Compare
Daylily-Zeleen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that if a base class has signals and it child class has not signal, call child class'
get_script_signal_list()will receive a list which containing duplicate base class signals.This pr do these:
GodotJSScript::has_script_signal.Now, GodotJSScript/GodotJSScriptInstance should similar to GDScript/GDScriptInstance.
Close #183 .