Thoughts and comments on moving quickjs to a thirdparty directory?

[fire]

Thoughts and comments on moving quickjs to a thirdparty directory?

I did in my branch but wanted commentary.

[Geequlim]

Do you mean the thirdparty folder of godot?
I don't think it's a good idea. It's simpler to simple clone the repo to godot modules folder and build it for other developers.

[Geequlim]

This module should contains all the dependencies. In V8 or nodejs backend the static libraries will be included instead of build from code with scons.

[fire]

you misunderstood.

1. javascript/quickjs/quickjs -> javascript/thirdparty/quickjs

[fire]

For example:

1. javascript/thirdparty/quickjs
2. javascript/thirdparty/v8
3. javascript/thirdparty/wasm3

[Geequlim]

That's looks good to me

[fire]

My pr here #156 moves the quickjs folder to thirdparty.

[fire]

Closing after merge. 9a3cd3f