Godot 4 Builds via Github Actions #149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly stop compiling the editor tools in the template builds, and install vulkan sdk so we get further along in the mac build
…ore that can be re-enabled
Contributor
Author
|
Also just now realized there's a script that generates the Github Actions from the main repo 🤦 Probably would've saved a few commits if I just read the README fully 🙃 Will try that out to see if gives a cleaner result than the manual edits I did here. 🤞 |
Collaborator
|
Good work! |
Collaborator
|
@animanmaster Are you able to work on this in the next two weeks? |
Collaborator
|
Thanks for your work. @Geequlim @animanmaster As #150 is merged, this can be closed. |
Collaborator
|
Thanks! |
Contributor
Author
|
Sorry for the delay, thanks for picking this up @fire. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes managed to get me working Godot 4 + Ecmascript builds via Github Actions. I've only done light testing with the Windows editor build and my own project, so definitely needs more testing to make sure everything works as expected, and there's more cleanup work that should be done to the Github Actions, but I figured I'd make this PR in case it helps/inspires others to take it further. :)