Skip to content

Update Go to 1.24 and use gotestsum #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReneWerner87 merged 2 commits into from
Jul 9, 2025
Merged

Update Go to 1.24 and use gotestsum #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c79f08
build: update go to 1.24 and improve tests
ReneWerner87 Jul 9, 2025
407c35d
📚 Doc: update install instructions for Go 1.24
ReneWerner87 Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.22.x
go-version: 1.24.x
- name: Run Golint
uses: reviewdog/action-golangci-lint@v2
with:
Expand Down
18 changes: 7 additions & 11 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jobs:
Build:
strategy:
matrix:
go-version: [1.21.x, 1.22.x]
go-version: [1.24.x]
platform: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.platform }}
steps:
Expand All @@ -14,14 +14,10 @@ jobs:
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
- name: Cache modules
uses: actions/cache@v3
with:
path: |
~/go/pkg/mod
~/.cache/go-build
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
cache: true
cache-dependency-path: '**/go.sum'
- name: Install gotestsum
run: go install gotest.tools/gotestsum@latest
- name: Run Test
run: go test ./... -v -race
run: |
gotestsum --format standard-verbose -- -race ./...
7 changes: 2 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,11 @@ Fiber Command Line Interface
[![Packaging status](https://repology.org/badge/vertical-allrepos/fiber-cli.svg)](https://repology.org/project/fiber-cli/versions)

# Installation
Requires Go 1.24 or later.

```bash
# for go version since 1.16
go install github.com/gofiber/cli/fiber@latest
Comment on lines 6 to 10
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify feasibility of requiring Go 1.24 before the toolchain is publicly available

Go 1.24 is not released at the time of writing (latest stable is 1.22). Mandating it in the README may block new users who follow the instructions today.
Please double-check:

  1. Whether any source change truly needs Go 1.24 features.
  2. That go.mod has been bumped to go 1.24 for consistency.
  3. CI matrices and Docker images support the new version.

If 1 and 2 are not strictly required yet, consider stating “Go ≥ 1.22 (tested with 1.24beta)” instead, or add a note that 1.24 is currently in beta.

🏁 Script executed:

#!/bin/bash
set -e

echo "Checking go.mod for Go version requirement:"
sed -n 's/^go //p' go.mod || echo "go.mod not found or no ‘go’ directive present."

echo ""
echo "Searching CI workflows for Go version usage with setup-go:"
grep -R "uses: .*actions/setup-go" -n .github/workflows || echo "No setup-go usage found in .github/workflows."

echo ""
echo "Scanning Dockerfile(s) for Go version in base image:"
grep -R "^FROM.*golang" -n . || echo "No Dockerfile with golang base image found."

Length of output: 888

🏁 Script executed:

#!/bin/bash
set -e

echo "Locating go.mod in the repository:"
find . -type f -name go.mod || echo "No go.mod file found."

echo ""
echo "Locating GitHub Actions workflows:"
find .github/workflows -type f -name '*.yml' -o -name '*.yaml' 2>/dev/null || echo "No workflow files found under .github/workflows."

echo ""
echo "Searching for setup-go usage across repository:"
grep -R "actions/setup-go" -n . || echo "No setup-go references found."

echo ""
echo "Locating Dockerfile(s) in the repository:"
find . -type f -iname 'Dockerfile*' || echo "No Dockerfile(s) found."

Length of output: 738

🏁 Script executed:

#!/bin/bash
set -e

echo "Fetching go.mod from gofiber/cli repository and extracting Go version requirement:"
curl -sSL https://raw.githubusercontent.com/gofiber/cli/main/go.mod | sed -n 's/^go //p' || echo "Failed to fetch or parse go.mod"

Length of output: 274

🏁 Script executed:

#!/bin/bash
set -e

echo "Checking 'go' directive in remote go.mod (master branch):"
curl -sSL https://raw.githubusercontent.com/gofiber/cli/master/go.mod | grep '^go ' || echo "No 'go' directive found in remote go.mod"

Length of output: 233

Align Go version requirement in README with codebase
The README now states “Requires Go 1.24 or later,” but the project’s remote go.mod is still set to go 1.21, and there are no CI workflows or Dockerfiles testing Go 1.24. Please:

  • Verify whether any new changes actually depend on Go 1.24 language or stdlib features.
  • If Go 1.24 is required:
    • Bump the go directive in go.mod to 1.24.
    • Add or update CI (e.g., GitHub Actions setup-go) to include Go 1.24.
    • Ensure any Dockerfiles use a Go 1.24 base image.
  • Otherwise, adjust the README to reflect the current minimum supported version. For example: 
    - Requires Go 1.24 or later.
+ Requires Go ≥ 1.21 (tested with Go 1.24 beta).

This will keep documentation, module settings, and CI in sync.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Installation
Requires Go 1.24 or later.
```bash
# for go version since 1.16
go install github.com/gofiber/cli/fiber@latest
# Installation
- Requires Go 1.24 or later.
+ Requires Go ≥ 1.21 (tested with Go 1.24 beta).
🤖 Prompt for AI Agents 
In README.md lines 6 to 10, the stated Go version requirement (1.24) is
inconsistent with the go.mod file and CI configurations that currently use Go
1.21. Verify if any code changes require Go 1.24 features; if so, update the
go.mod 'go' directive to 1.24, modify CI workflows to test with Go 1.24, and
update Dockerfiles to use a Go 1.24 base image. If not, change the README to
reflect the current minimum Go version (1.21) to keep documentation, module
settings, and CI aligned.

```
```bash
# for go version smaller than 1.16
go get -u github.com/gofiber/cli/fiber
```

# Commands
## fiber
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/gofiber/cli

go 1.21
go 1.24
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change updates the project to require Go 1.24, which is a future, unreleased version. Depending on an unstable toolchain is risky as it can lead to unexpected build breakages and creates a higher barrier for contributors to set up their environment.

It is strongly recommended to use the latest stable Go version (e.g., 1.22) to maintain project stability. If this change is intentional and there's a strong reason to depend on a future version, it would be beneficial to document it in the project's contribution guidelines or README.


require (
github.com/charmbracelet/bubbles v0.18.0
Expand Down
Loading