Skip to content

Add regression test for encryptcookie migrator idempotency #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReneWerner87 merged 1 commit into from
Oct 8, 2025
Merged

Add regression test for encryptcookie migrator idempotency #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions cmd/internal/migrations/v3/encryptcookie_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,30 @@ var _ = encryptcookie.New(encryptcookie.Config{
second := readFile(t, file)
assert.Equal(t, first, second)
}

func Test_MigrateEncryptcookieConfig_EncryptorDecryptorMigrated(t *testing.T) {
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test function name Test_MigrateEncryptcookieConfig_EncryptorDecryptorMigrated is a bit inconsistent with the existing Test_MigrateEncryptcookieConfig_Idempotent test. Since this test also verifies idempotency, but for a more specific case, consider renaming it to better reflect its purpose and align with existing test names. A more consistent name could be Test_MigrateEncryptcookieConfig_Idempotent_EncryptorDecryptor. This improves consistency and makes the test suite easier to understand.

Suggested change
func Test_MigrateEncryptcookieConfig_EncryptorDecryptorMigrated(t *testing.T) {
func Test_MigrateEncryptcookieConfig_Idempotent_EncryptorDecryptor(t *testing.T) {

t.Parallel()

dir, err := os.MkdirTemp("", "mencryptcookiealready")
require.NoError(t, err)
defer func() { require.NoError(t, os.RemoveAll(dir)) }()

input := `package main
import (
"github.com/gofiber/fiber/v2/middleware/encryptcookie"
)
var _ = encryptcookie.New(encryptcookie.Config{
Encryptor: func(_ string, value, key string) (string, error) { return "", nil },
Decryptor: func(_ string, value string, key string) (string, error) { return "", nil },
})`

file := writeTempFile(t, dir, input)

var buf bytes.Buffer
cmd := newCmd(&buf)
require.NoError(t, v3.MigrateEncryptcookieConfig(cmd, dir, nil, nil))

content := readFile(t, file)
assert.Equal(t, input, content)
assert.Empty(t, buf.String())
}
Loading