Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/internal/migrations/v3/jwt_extractor.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
)

func MigrateJWTExtractor(cmd *cobra.Command, cwd string, _, _ *semver.Version) error {
reImport := regexp.MustCompile(`(?m)^\s*(?:import\s+)?(?:([\w\.]+)\s+)?"github\.com/gofiber/contrib/jwt(?:/v\d+)?"`)
reImport := regexp.MustCompile(`(?m)^\s*(?:import\s+)?(?:([\w\.]+)\s+)?"github\.com/gofiber/(?:contrib/)?jwt(?:/v\d+)?"(?:\s*//[^\n]*)?`)
reAuthScheme := regexp.MustCompile(`(?m)^\s*AuthScheme:\s*([^,\n]+)`)
reAuthLine := regexp.MustCompile(`(?m)^\s*AuthScheme:\s*[^\n]+\n?`)
reFilter := regexp.MustCompile(`(?m)^(\s*)Filter:\s*`)
Expand Down
67 changes: 65 additions & 2 deletions cmd/internal/migrations/v3/jwt_extractor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var _ = jwtware.New(jwtware.Config{
content := readFile(t, file)
assert.NotContains(t, content, "TokenLookup")
assert.NotContains(t, content, "AuthScheme")
assert.Contains(t, content, `Extractor: extractors.Chain(extractors.FromAuthHeader("Token"), extractors.FromCookie("jwt"))`)
assert.Regexp(t, `Extractor:\s*extractors.Chain\(extractors.FromAuthHeader\("Token"\),\s*extractors.FromCookie\("jwt"\)\)`, content)
assert.Contains(t, content, "Next:")
assert.Contains(t, content, "func(c fiber.Ctx) bool { return false },")
assert.Contains(t, content, `"github.com/gofiber/fiber/v3/extractors"`)
Expand Down Expand Up @@ -89,7 +89,70 @@ var _ = authjwt.New(authjwt.Config{

content := readFile(t, file)
assert.NotContains(t, content, "TokenLookup")
assert.Contains(t, content, `Extractor: extractors.FromCookie("session")`)
assert.Regexp(t, `Extractor:\s*extractors.FromCookie\("session"\)`, content)
assert.Contains(t, content, `"github.com/gofiber/fiber/v3/extractors"`)
assert.Contains(t, buf.String(), "Migrating jwt middleware configs")
}

func Test_MigrateJWTExtractor_ImportWithComment(t *testing.T) {
t.Parallel()

dir, err := os.MkdirTemp("", "mjwt_comment")
require.NoError(t, err)
defer func() { require.NoError(t, os.RemoveAll(dir)) }()

file := writeTempFile(t, dir, `package main
import (
jwtware "github.com/gofiber/contrib/jwt" // jwt middleware
"github.com/gofiber/fiber/v2"
)

func JWTMiddleware() fiber.Handler {
return jwtware.New(jwtware.Config{
TokenLookup: "cookie:jwt",
})
}`)

var buf bytes.Buffer
cmd := newCmd(&buf)
require.NoError(t, v3.MigrateJWTExtractor(cmd, dir, nil, nil))

content := readFile(t, file)
assert.NotContains(t, content, "TokenLookup")
assert.Regexp(t, `Extractor:\s*extractors.FromCookie\("jwt"\)`, content)
assert.Contains(t, content, `"github.com/gofiber/fiber/v3/extractors"`)
assert.Contains(t, buf.String(), "Migrating jwt middleware configs")
}

func Test_MigrateJWTExtractor_LegacyImportPath(t *testing.T) {
t.Parallel()

dir, err := os.MkdirTemp("", "mjwt_legacy")
require.NoError(t, err)
defer func() { require.NoError(t, os.RemoveAll(dir)) }()

file := writeTempFile(t, dir, `package main
import (
jwtware "github.com/gofiber/jwt/v2"
"github.com/gofiber/fiber/v2"
)

func JWTMiddleware() fiber.Handler {
return jwtware.New(jwtware.Config{
ErrorHandler: jwtError,
SigningKey: jwtware.SigningKey{Key: []byte(os.Getenv("JWT_SECRET"))},
TokenLookup: "cookie:jwt",
})
}
`)
Comment thread
ReneWerner87 marked this conversation as resolved.

var buf bytes.Buffer
cmd := newCmd(&buf)
require.NoError(t, v3.MigrateJWTExtractor(cmd, dir, nil, nil))

content := readFile(t, file)
assert.NotContains(t, content, "TokenLookup")
assert.Regexp(t, `Extractor:\s*extractors.FromCookie\("jwt"\)`, content)
assert.Contains(t, content, `"github.com/gofiber/fiber/v3/extractors"`)
assert.Contains(t, buf.String(), "Migrating jwt middleware configs")
}
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ require (
github.com/spf13/pflag v1.0.10
github.com/stretchr/testify v1.11.1
golang.org/x/mod v0.28.0
golang.org/x/sync v0.18.0
golang.org/x/tools v0.37.0
)

Expand Down Expand Up @@ -53,7 +54,6 @@ require (
github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
golang.org/x/crypto v0.42.0 // indirect
golang.org/x/net v0.44.0 // indirect
golang.org/x/sync v0.18.0 // indirect
golang.org/x/sys v0.36.0 // indirect
golang.org/x/text v0.29.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ golang.org/x/mod v0.28.0 h1:gQBtGhjxykdjY9YhZpSlZIsbnaE2+PgjfLWUQTnoZ1U=
golang.org/x/mod v0.28.0/go.mod h1:yfB/L0NOf/kmEbXjzCPOx1iK1fRutOydrCMsqRhEBxI=
golang.org/x/net v0.44.0 h1:evd8IRDyfNBMBTTY5XRF1vaZlD+EmWx6x8PkhR04H/I=
golang.org/x/net v0.44.0/go.mod h1:ECOoLqd5U3Lhyeyo/QDCEVQ4sNgYsqvCZ722XogGieY=
golang.org/x/sync v0.17.0 h1:l60nONMj9l5drqw6jlhIELNv9I0A4OFgRsG9k2oT9Ug=
golang.org/x/sync v0.17.0/go.mod h1:9KTHXmSnoGruLpwFjVSX0lNNA75CykiMECbovNTZqGI=
golang.org/x/sync v0.18.0 h1:kr88TuHDroi+UVf+0hZnirlk8o8T+4MrK6mr60WkH/I=
golang.org/x/sync v0.18.0/go.mod h1:9KTHXmSnoGruLpwFjVSX0lNNA75CykiMECbovNTZqGI=
golang.org/x/sys v0.0.0-20210809222454-d867a43fc93e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
Expand Down
Loading