🩹 Fix: Fixed Adapter Otelfiber c.BaseURL() issue#2765
Closed
rharshit82 wants to merge 2 commits into
Closed
Conversation
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Member
|
@rharshit82 Can you check for that field in the unit-tests. Thanks |
ReneWerner87
approved these changes
Dec 18, 2023
3 tasks
Member
|
@rharshit82 we are only waiting for an extension of the unittests for the new functionality, otherwise it is not guaranteed that after each code update the functionality works as expected and it can lead to errors, which we want to prevent directly during the initial implementation |
Member
|
closed by #2772 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It solves Adaptator + otelfiber issue bug where combination of Adaptator + Otelfiber contrib Middleware, c.BaseURL() returns wrong value (http:// instead of http://localhost:3000)
issue link
Detailed explanation of solution of this issue is mentioned in here
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: CONTRIBUTING.md