fix: Apply default timeout on negative values and optimize skip path …#3519
Conversation
|
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Andrei-hub11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the robustness and performance of the timeout middleware. It addresses a potential configuration issue by handling negative timeout values and includes two minor performance optimizations related to initializing the skip path map and checking for custom errors.
Highlights
- Configuration Robustness: Added a check to ensure that a negative timeout value provided in the configuration is replaced with the default timeout value, preventing potential issues with invalid settings.
- Performance Optimization (Skip Paths): Optimized the creation of the internal map used for checking skipped paths by pre-allocating its capacity based on the number of paths provided in the configuration. This can reduce reallocations and improve performance when setting up the middleware.
- Performance Optimization (Error Handling): Modified the error handling logic to avoid iterating through the list of custom errors if no custom errors are configured. This prevents an unnecessary loop in the
isCustomErrorhelper function when theErrorsslice is empty.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses several points to improve the timeout middleware. It correctly handles negative timeout values by defaulting them to the standard configuration, which prevents potential unexpected behavior. The optimization for building the skip path map by pre-allocating capacity is a good practice for performance, especially with larger lists of skipped paths. Additionally, the change to conditionally check the length of the custom errors slice before iterating avoids an unnecessary function call and loop when no custom errors are configured, contributing to minor efficiency gains. The changes are well-implemented and align with the pull request description.
|
@Andrei-hub11 Thanks, will review in the morning |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## codex/2025-06-13-14-24-16 #3519 +/- ##
=============================================================
- Coverage 83.92% 83.89% -0.03%
=============================================================
Files 121 121
Lines 12324 12322 -2
=============================================================
- Hits 10343 10338 -5
- Misses 1557 1559 +2
- Partials 424 425 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Andrei-hub11 Running |
gaby
merged commit 43c5a2f
into
gofiber:codex/2025-06-13-14-24-16
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
2 participants
@gaby, this PR fixes what I suggested earlier.
It makes sure a default timeout is used if a wrong (negative) value is set.
It speeds up how skipped paths are set up.
It also avoids an unnecessary loop.