docs(logger): clarify ${bytesSent} behavior in logger middleware#4251
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis PR adds a documentation tip to the logger middleware explaining that ChangesLogger Middleware Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 12 minutes and 53 seconds.Comment |
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the ${bytesSent} variable in the logger middleware. The review feedback suggests refining the technical accuracy of the explanation regarding missing headers and using a callout block to align with the project's documentation style.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Summary
Clarifies the behavior of the
${bytesSent}logger tag in the middleware documentation.Changes
${bytesSent}is based on theContent-Lengthresponse header0whenContent-Lengthis not set-1for streaming responsesNotes
Validation
${bytesSent}