🪓 Code separation for utils (🧹clean code)#771
Merged
Conversation
Co-authored-by: Fenny <fenny@gofiber.io> Co-authored-by: Kiyon <kiyon@gofiber.io>
ReneWerner87
requested review from
Fenny and
thomasvvugt
and removed request for
a team
Co-authored-by: Fenny <fenny@gofiber.io> Co-authored-by: Kiyon <kiyon@gofiber.io>
Co-authored-by: Fenny <fenny@gofiber.io> Co-authored-by: Kiyon <kiyon@gofiber.io>
Co-authored-by: Fenny <fenny@gofiber.io> Co-authored-by: Kiyon <kiyon@gofiber.io>
Co-authored-by: Fenny <fenny@gofiber.io> Co-authored-by: Kiyon <kiyon@gofiber.io>
gtoxlili
pushed a commit
to gtoxlili/fiber
that referenced
this pull request
May 9, 2026
The "Working with RequestCtx and fasthttpctx" section and the Summary bullet claimed that `RequestCtx.Done` closes when the client connection ends. That is not what fasthttp actually does — `s.done` is the shared server-wide channel and only closes on `Server.Shutdown`. Per-connection disconnect detection is not currently provided by fasthttp. Sources: - valyala/fasthttp `server.go` comment on `RequestCtx.Done`: "RequestCtx.s.done is only closed when the server is shutting down" - valyala/fasthttp#468, gofiber#771, gofiber#965 — upstream maintainers confirm in-handler client disconnect detection is not supported - gofiber#805 (Fenny: "not possible nor efficient with fasthttp sync.pool design") and gofiber#1718 (same Q&A, closed with the same answer) - gofiber#4145 — open proposal asking for the very capability the docs already advertised Updates three spots in docs/guide/context.md: 1. The fasthttpctx paragraph — now describes the actual semantics and points readers to timeout / Flush-based detection for long handlers. 2. The "Context Cancellation with Goroutines" paragraph — drops the misleading "client disconnects" phrasing. 3. The Summary bullet — matches the corrected description. Fixes gofiber#4263
gtoxlili
pushed a commit
to gtoxlili/fiber
that referenced
this pull request
May 9, 2026
The "Working with RequestCtx and fasthttpctx" section and the Summary bullet claimed that `RequestCtx.Done` closes when the client connection ends. That is not what fasthttp actually does — `s.done` is the shared server-wide channel and only closes on `Server.Shutdown`. Per-connection disconnect detection is not currently provided by fasthttp. Sources: - valyala/fasthttp `server.go` comment on `RequestCtx.Done`: "RequestCtx.s.done is only closed when the server is shutting down" - valyala/fasthttp#468, gofiber#771, gofiber#965 — upstream maintainers confirm in-handler client disconnect detection is not supported - gofiber#805 (Fenny: "not possible nor efficient with fasthttp sync.pool design") and gofiber#1718 (same Q&A, closed with the same answer) - gofiber#4145 — open proposal asking for the very capability the docs already advertised Updates three spots in docs/guide/context.md: 1. The fasthttpctx paragraph — now describes the actual semantics and points readers to timeout / Flush-based detection for long handlers. 2. The "Context Cancellation with Goroutines" paragraph — drops the misleading "client disconnects" phrasing. 3. The Summary bullet — matches the corrected description. Fixes gofiber#4263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Fenny fenny@gofiber.io
Co-authored-by: Kiyon kiyon@gofiber.io
🪓 Code separation for utils (🧹clean code)