Update to Fiber v3 beta#382
Conversation
thomasvvugt
requested review from
ReneWerner87,
efectn,
gaby and
sixcolors
and removed request for
a team
WalkthroughThe overall change involves updating the import path for the Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (9)
Files selected for processing (7)
Files skipped from review due to trivial changes (6)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
jet/jet.go (2)
Line range hint
25-34: Consider improving error handling strategy.Instead of using
log.Fatalf, which terminates the program, return an error to allow the caller to handle it gracefully. This approach improves the testability and robustness of the application.- log.Fatalf("%s Extension is not a valid jet engine ['.html.jet', .jet.html', '.jet']", extension) + return nil, fmt.Errorf("%s Extension is not a valid jet engine ['.html.jet', .jet.html', '.jet']", extension)
Line range hint
106-106: Add a type assertion check to prevent runtime panics.The type assertion
l := loader.(*jet.InMemLoader)could cause a runtime panic ifloaderis not actually of type*jet.InMemLoader. It's safer to add a check:- l := loader.(*jet.InMemLoader) //nolint:errcheck,forcetypeassert + l, ok := loader.(*jet.InMemLoader) + if !ok { + return fmt.Errorf("unexpected loader type: %T", loader) + }
|
thx but lets wait for the RC version |
ReneWerner87
left a comment
ReneWerner87
left a comment
There was a problem hiding this comment.
lets wait for the RC release
| @@ -1,3 +1,3 @@ | |||
| module github.com/gofiber/template | |||
There was a problem hiding this comment.
its a breaking change, we need to change the version of this sub-package
| @@ -1,30 +1,31 @@ | |||
| module github.com/gofiber/template/handlebars/v2 | |||
There was a problem hiding this comment.
its a breaking change, we need to change the version of this sub-package
| @@ -1,30 +1,31 @@ | |||
| module github.com/gofiber/template/jet/v2 | |||
There was a problem hiding this comment.
its a breaking change, we need to change the version of this sub-package
| @@ -1,29 +1,30 @@ | |||
| module github.com/gofiber/template/mustache/v2 | |||
There was a problem hiding this comment.
its a breaking change, we need to change the version of this sub-package
|
Replaced by #437 |
3 participants
Fix for #333
Main issue was the fiber.Map type not coming from gofiber/fiber/v3 but gofiber/fiber/v2.
Summary by CodeRabbit