Skip to content

Add UUID alias for UUIDv4 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReneWerner87 merged 1 commit into from
Dec 23, 2025
Merged

Add UUID alias for UUIDv4 #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ func UUIDv4() string {
return token.String()
}

// UUID generates an universally unique identifier (UUID).
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a minor grammatical error here. The word "universally" starts with a consonant sound, so it should be preceded by "a" instead of "an".

Suggested change
// UUID generates an universally unique identifier (UUID).
// UUID generates a universally unique identifier (UUID).

Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar error: "an universally" should be "a universally". The article "a" is used before words beginning with a consonant sound, and "universally" starts with a "y" sound (you-niversally).

Suggested change
// UUID generates an universally unique identifier (UUID).
// UUID generates a universally unique identifier (UUID).

Copilot uses AI. Check for mistakes.
// This is an alias for UUIDv4 for backward compatibility.
func UUID() string {
return UUIDv4()
}
Comment on lines +53 to +55
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new UUID function lacks test coverage. Similar functions in common.go have corresponding tests in common_test.go. For example, UUIDv4 has Test_UUIDv4 and Test_UUIDv4_Concurrency. Consider adding at least a basic test for UUID to ensure it returns a valid UUID string, similar to how UUIDv4 is tested.

Copilot uses AI. Check for mistakes.

// GenerateSecureToken generates a cryptographically secure random token encoded in base64.
// It uses crypto/rand for randomness and base64.RawURLEncoding for URL-safe output.
// If length is less than or equal to 0, it defaults to 32 bytes (256 bits of entropy).
Expand Down
Loading