Skip to content

Conversation

@bupd
Copy link
Contributor

@bupd bupd commented Apr 16, 2025

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd requested a review from a team as a code owner April 16, 2025 11:07
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj
Copy link
Contributor

The script of e2e_container.sh already mount the ca.crt to the e2e container.

@chlins chlins added the release-note/infra Infra related changes e.g. release, test, ship etc... label Apr 23, 2025
Signed-off-by: bupd <bupdprasanth@gmail.com>
@chlins chlins enabled auto-merge (squash) April 23, 2025 02:58
@chlins chlins merged commit 9850f14 into goharbor:main Apr 23, 2025
10 checks passed
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request May 16, 2025
add missing step in e2e

Signed-off-by: bupd <bupdprasanth@gmail.com>
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
add missing step in e2e

Signed-off-by: bupd <bupdprasanth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/infra Infra related changes e.g. release, test, ship etc...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants