Skip to content

Conversation

@stonezdj
Copy link
Contributor

@stonezdj stonezdj commented May 8, 2025

fix #21411

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner May 8, 2025 04:43
@stonezdj stonezdj added the release-note/new-feature New Harbor Feature label May 8, 2025
  fix goharbor#21411

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj force-pushed the 25may08_display_gc_progress branch from b25503b to ce87d1d Compare May 8, 2025 04:45
@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.50%. Comparing base (c8c11b4) to head (ce87d1d).
Report is 471 commits behind head on main.

Files with missing lines Patch % Lines
...-job/gc-page/gc/gc-history/gc-history.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21974      +/-   ##
==========================================
+ Coverage   45.36%   46.50%   +1.13%     
==========================================
  Files         244      253       +9     
  Lines       13333    14236     +903     
  Branches     2719     2924     +205     
==========================================
+ Hits         6049     6620     +571     
- Misses       6983     7265     +282     
- Partials      301      351      +50     
Flag Coverage Δ
unittests 46.50% <0.00%> (+1.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-job/gc-page/gc/gc-history/gc-history.component.ts 40.00% <0.00%> (ø)

... and 177 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 49df3b4 into goharbor:main May 8, 2025
11 of 12 checks passed
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request May 16, 2025
fix goharbor#21411

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
fix goharbor#21411

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GC should display the progress information at running status

5 participants