Skip to content

Conversation

@miledxz
Copy link
Contributor

@miledxz miledxz commented May 12, 2025

Comprehensive Summary of your change

Update for src/jobservice/common/list/list_test.go to test does list length increases when pushing nil value

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@miledxz miledxz requested a review from a team as a code owner May 12, 2025 13:33
@miledxz miledxz force-pushed the test-list-update branch from f8e2cf5 to d486b6d Compare May 12, 2025 13:35
@miledxz miledxz changed the title test list update Test update for adding nil value to list May 12, 2025
@wy65701436 wy65701436 requested a review from Copilot May 13, 2025 09:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new test case to verify that pushing a nil value does not increase the length of the list.

  • Adds TestPushNil in list_test.go to confirm that the list length remains unchanged when a nil value is pushed.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: miledxz <zedsprogramms@gmail.com>
@chlins chlins force-pushed the test-list-update branch from d486b6d to d653aae Compare May 13, 2025 09:11
@Vivekgaddigi
Copy link

@miledxz Update the branch
lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 enabled auto-merge (squash) May 15, 2025 05:50
@chlins chlins added the release-note/update Update or Fix label May 15, 2025
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.45%. Comparing base (c8c11b4) to head (8569afe).
Report is 478 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21990      +/-   ##
==========================================
+ Coverage   45.36%   46.45%   +1.08%     
==========================================
  Files         244      253       +9     
  Lines       13333    14238     +905     
  Branches     2719     2925     +206     
==========================================
+ Hits         6049     6614     +565     
- Misses       6983     7272     +289     
- Partials      301      352      +51     
Flag Coverage Δ
unittests 46.45% <ø> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wy65701436 wy65701436 merged commit 424cdd8 into goharbor:main May 15, 2025
12 of 13 checks passed
wy65701436 added a commit to wy65701436/harbor that referenced this pull request May 16, 2025
test list update

Signed-off-by: miledxz <zedsprogramms@gmail.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
TMHBOFH pushed a commit to TMHBOFH/harbor that referenced this pull request May 21, 2025
test list update

Signed-off-by: miledxz <zedsprogramms@gmail.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
Signed-off-by: TMHBOFH <itsystem.bofh@gmail.com>
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
test list update

Signed-off-by: miledxz <zedsprogramms@gmail.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants