-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Test update for adding nil value to list #21990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new test case to verify that pushing a nil value does not increase the length of the list.
- Adds TestPushNil in list_test.go to confirm that the list length remains unchanged when a nil value is pushed.
chlins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: miledxz <zedsprogramms@gmail.com>
|
@miledxz Update the branch |
wy65701436
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21990 +/- ##
==========================================
+ Coverage 45.36% 46.45% +1.08%
==========================================
Files 244 253 +9
Lines 13333 14238 +905
Branches 2719 2925 +206
==========================================
+ Hits 6049 6614 +565
- Misses 6983 7272 +289
- Partials 301 352 +51
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
test list update Signed-off-by: miledxz <zedsprogramms@gmail.com> Co-authored-by: Wang Yan <wangyan@vmware.com>
test list update Signed-off-by: miledxz <zedsprogramms@gmail.com> Co-authored-by: Wang Yan <wangyan@vmware.com> Signed-off-by: TMHBOFH <itsystem.bofh@gmail.com>
test list update Signed-off-by: miledxz <zedsprogramms@gmail.com> Co-authored-by: Wang Yan <wangyan@vmware.com>
Comprehensive Summary of your change
Update for
src/jobservice/common/list/list_test.goto test does list length increases when pushingnil valuePlease indicate you've done the following: