-
Notifications
You must be signed in to change notification settings - Fork 5.1k
change the pass-CI rules to exclude the resources and robot-cases folder #22121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22121 +/- ##
===========================================
+ Coverage 45.36% 65.87% +20.50%
===========================================
Files 244 1071 +827
Lines 13333 115703 +102370
Branches 2719 2925 +206
===========================================
+ Hits 6049 76220 +70171
- Misses 6983 35254 +28271
- Partials 301 4229 +3928
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
chlins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ee04a24 to
da3255d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adjust CI configurations to skip resource and robot-case directories and update test scripts to use the proper Harbor admin credentials.
- Replace hard-coded
Harbor12345password with${HARBOR_ADMIN_PASSWD}and add${HARBOR_ADMIN}to Robot test runs - Exclude
tests/resources/**andtests/robot-cases/**from CI triggers inpass-CI.yml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/ci/api_run.sh | Updated Docker-run commands to use ${HARBOR_ADMIN_PASSWD} and ${HARBOR_ADMIN} instead of hard-coded password |
| .github/workflows/pass-CI.yml | Added tests/resources/** and tests/robot-cases/** to paths-ignore for pull requests and pushes |
Comments suppressed due to low confidence (2)
tests/ci/api_run.sh:23
- [nitpick] The host variable
HARBOR_ADMIN_PASSWDmaps into the container asHARBOR_PASSWORD, which could be misleading. Consider unifying the naming (e.g., useHARBOR_ADMIN_PASSWORDboth on host and container) to improve clarity.
docker run -i --privileged -v $DIR/../../:/drone -v $DIR/../:/ca -w /drone $E2E_IMAGE robot --exclude proxy_cache -v DOCKER_USER:${DOCKER_USER} -v DOCKER_PWD:${DOCKER_PWD} -v ip:$2 -v ip1: -v http_get_ca:false -v HARBOR_PASSWORD:${HARBOR_ADMIN_PASSWD} -v HARBOR_ADMIN:${HARBOR_ADMIN} /drone/tests/robot-cases/Group1-Nightly/Setup.robot /drone/tests/robot-cases/Group0-BAT/API_DB.robot
.github/workflows/pass-CI.yml:12
- [nitpick] The
paths-ignoreentries for pull requests and pushes are duplicated. You could use a YAML anchor or a single reusable list to DRY up the workflow configuration.
- '!tests/resources/**'
Pass HARBOR_ADMIN env to robot testcases Signed-off-by: stonezdj <stone.zhang@broadcom.com>
da3255d to
3866cc4
Compare
…der (goharbor#22121) Change the pass-CI rules to exclude the resources and robot-cases folder Pass HARBOR_ADMIN env to robot testcases Signed-off-by: stonezdj <stone.zhang@broadcom.com> Signed-off-by: AYDEV-FR <aymeric.deliencourt@aydev.fr>
…der (goharbor#22121) Change the pass-CI rules to exclude the resources and robot-cases folder Pass HARBOR_ADMIN env to robot testcases Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: