Skip to content

Conversation

@stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner June 26, 2025 03:33
@stonezdj stonezdj added the release-note/infra Infra related changes e.g. release, test, ship etc... label Jun 26, 2025
@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.87%. Comparing base (c8c11b4) to head (3866cc4).
Report is 498 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22121       +/-   ##
===========================================
+ Coverage   45.36%   65.87%   +20.50%     
===========================================
  Files         244     1071      +827     
  Lines       13333   115703   +102370     
  Branches     2719     2925      +206     
===========================================
+ Hits         6049    76220    +70171     
- Misses       6983    35254    +28271     
- Partials      301     4229     +3928     
Flag Coverage Δ
unittests 65.87% <ø> (+20.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 985 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 25jun26_update_ci_pass branch 2 times, most recently from ee04a24 to da3255d Compare June 26, 2025 04:50
@stonezdj stonezdj requested review from MinerYang and Copilot June 26, 2025 04:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adjust CI configurations to skip resource and robot-case directories and update test scripts to use the proper Harbor admin credentials.

  • Replace hard-coded Harbor12345 password with ${HARBOR_ADMIN_PASSWD} and add ${HARBOR_ADMIN} to Robot test runs
  • Exclude tests/resources/** and tests/robot-cases/** from CI triggers in pass-CI.yml

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/ci/api_run.sh Updated Docker-run commands to use ${HARBOR_ADMIN_PASSWD} and ${HARBOR_ADMIN} instead of hard-coded password
.github/workflows/pass-CI.yml Added tests/resources/** and tests/robot-cases/** to paths-ignore for pull requests and pushes
Comments suppressed due to low confidence (2)

tests/ci/api_run.sh:23

  • [nitpick] The host variable HARBOR_ADMIN_PASSWD maps into the container as HARBOR_PASSWORD, which could be misleading. Consider unifying the naming (e.g., use HARBOR_ADMIN_PASSWORD both on host and container) to improve clarity.
    docker run -i --privileged -v $DIR/../../:/drone -v $DIR/../:/ca -w /drone $E2E_IMAGE robot --exclude proxy_cache -v DOCKER_USER:${DOCKER_USER} -v DOCKER_PWD:${DOCKER_PWD} -v ip:$2  -v ip1: -v http_get_ca:false -v HARBOR_PASSWORD:${HARBOR_ADMIN_PASSWD} -v HARBOR_ADMIN:${HARBOR_ADMIN} /drone/tests/robot-cases/Group1-Nightly/Setup.robot /drone/tests/robot-cases/Group0-BAT/API_DB.robot

.github/workflows/pass-CI.yml:12

  • [nitpick] The paths-ignore entries for pull requests and pushes are duplicated. You could use a YAML anchor or a single reusable list to DRY up the workflow configuration.
      - '!tests/resources/**'

   Pass HARBOR_ADMIN env to robot testcases

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@reasonerjt reasonerjt merged commit b8e3dd8 into goharbor:main Jun 26, 2025
12 checks passed
AYDEV-FR pushed a commit to AYDEV-FR/harbor that referenced this pull request Jul 4, 2025
…der (goharbor#22121)

Change the pass-CI rules to exclude the resources and robot-cases folder
   Pass HARBOR_ADMIN env to robot testcases

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Signed-off-by: AYDEV-FR <aymeric.deliencourt@aydev.fr>
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
…der (goharbor#22121)

Change the pass-CI rules to exclude the resources and robot-cases folder
   Pass HARBOR_ADMIN env to robot testcases

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/infra Infra related changes e.g. release, test, ship etc...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants