Skip to content

Fix other build gaps in release-2.13.0 #22485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chlins merged 1 commit into from
Oct 21, 2025
Merged

Fix other build gaps in release-2.13.0 #22485

chlins merged 1 commit into from
Oct 21, 2025

Conversation

@MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Oct 21, 2025 •
edited
Loading

Thank you for contributing to Harbor!

Comprehensive Summary of your change

  1. change python ./setup.py install to pip install
  2. add exporterflag

cherry-pick of follow PRS

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang requested a review from a team as a code owner October 21, 2025 07:58
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-2.13.0@5b768a2). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.13.0   #22485   +/-   ##
=================================================
  Coverage                  ?   46.47%           
=================================================
  Files                     ?      253           
  Lines                     ?    14235           
  Branches                  ?     2925           
=================================================
  Hits                      ?     6616           
  Misses                    ?     7265           
  Partials                  ?      354
Flag Coverage Δ
unittests 46.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MinerYang
Fix other build gaps in release-2.13.0
b1fcf78 
1. change python ./setup.py install to pip install

Signed-off-by: my036811 <miner.yang@broadcom.com>

2. add build flag for harbor exporter

As the harbor exporter is not a core component for installation, so like the trivy, add a flag to controller whether package it into the offline installer.

Signed-off-by: wang yan <wangyan@vmware.com>
@MinerYang MinerYang added the release-note/update Update or Fix label Oct 21, 2025
@MinerYang MinerYang changed the title [WIP]Fix other build gaps in release-2.13.0 Fix other build gaps in release-2.13.0 Oct 21, 2025
chlins
chlins approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 2e107da into goharbor:release-2.13.0 Oct 21, 2025
19 checks passed
@OrlinVasilev
Copy link
Member

OrlinVasilev commented Oct 21, 2025

Hey @MinerYang you are missing https://github.com/goharbor/harbor/pull/21952/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R542

@MinerYang
Copy link
Contributor Author

MinerYang commented Oct 21, 2025

Hey @MinerYang you are missing https://github.com/goharbor/harbor/pull/21952/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R542

Thanks @OrlinVasilev for the remind! Some how miss this part.
I will have another pr to update it.^

@OrlinVasilev
Copy link
Member

OrlinVasilev commented Oct 21, 2025

fantastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stonezdj stonezdj stonezdj approved these changes

@chlins chlins chlins approved these changes

Assignees

@Vad1mo Vad1mo

@wy65701436 wy65701436

@OrlinVasilev OrlinVasilev

Labels

release-note/update Update or Fix target/2.13.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MinerYang @OrlinVasilev @stonezdj @chlins @Vad1mo @wy65701436