Skip to content

Added Tic_Tac_Toe game In Python#46

Merged
gohil-jay merged 3 commits intogohil-jay:mainfrom
Kavs-123:main
Oct 31, 2021
Merged

Added Tic_Tac_Toe game In Python#46
gohil-jay merged 3 commits intogohil-jay:mainfrom
Kavs-123:main

Conversation

@Kavs-123
Copy link

No description provided.

Copy link
Owner

@gohil-jay gohil-jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine, however, you need to change the code structure. The 'Tic Tac Toe' sub-repo (folder) is already present, and thus, please add your code file into that particular folder and name the file as 'app1.py' and screenshots as 'Screenshot1_1.png' and so on. Do the needful, and it will be merged.

@Kavs-123
Copy link
Author

The code seems fine, however, you need to change the code structure. The 'Tic Tac Toe' sub-repo (folder) is already present, and thus, please add your code file into that particular folder and name the file as 'app1.py' and screenshots as 'Screenshot1_1.png' and so on. Do the needful, and it will be merged.

I have performed the required Modifications @gohil-jay with branch name: 8f5e60a...
Pls review it

Copy link
Owner

@gohil-jay gohil-jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were only supposed to add you part in the sub-repo and not remove the original one. I have made the corrections. This is now good to go.

@gohil-jay gohil-jay merged commit 27b4a72 into gohil-jay:main Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants