Introduce the https://github.com/segmentio/golines linter

[tian000]

Is your feature request related to a problem? Please describe.
This linter actually fixes long lines which is very convenient.

Describe the solution you'd like
Please add this linter to golangci-lint

https://github.com/segmentio/golines

[boring-cyborg]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

[ldez]

Hello,

https://github.com/segmentio/golines

golines is a golang formatter that shortens long lines,

golines is not a linter but a formatter.

I think it's out of the scope of golangci-lint.

[tian000]

Aren't gofumpt and gofmt formatters, and yet they are part of golangci-lint?

[ldez]

They are used as linter, to handle long lines there is the lll linter inside golangci-lint.

[tian000]

lll does not automatically fix long lines for when using the --fix flag with golangci-lint. This is a convenience that golines would be able to provide.

[colinking]

@ldez if golines offered separate lint and fix modes which could be toggled via the --fix flag to golangci-lint, then could golines be added as a public linter? I'd love to see it since all of our linting/formatting goes through golangci-lint. I'd be happy to contribute here and downstream to golines to help get this through.

[ldez]

We already have lll to handle long lines, the lll code is inside golangci-lint.
A fix mode can be added to lll.
FYI I plan to rethink the fix/suggestion system inside golangci-lint.

[vitorf7]

@ldez One of the biggest gripes I have with lll is that it just looks and cares about a line length.
It does not take into account comments and struct tags. On the other hand golines takes that into account and it could fix comments with specific flags. I have added the request to maybe add a --lint flag or something so that it would have both linting and formatting functionality which means then it could definitely be used along with golangci-lint