Fix Recharts Tooltip labelFormatter TypeScript typing in ContactCard#61
Open
larsrojo wants to merge 1 commit intogommzystudio:masterfrom
Open
Fix Recharts Tooltip labelFormatter TypeScript typing in ContactCard#61larsrojo wants to merge 1 commit intogommzystudio:masterfrom
larsrojo wants to merge 1 commit intogommzystudio:masterfrom
Conversation
mazimy1980-art
approved these changes
Jan 25, 2026
fazelukario
added a commit
to fazelukario/device-activity-tracker
that referenced
this pull request
Feb 3, 2026
|
cteate a WhatsApp tracking website |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a TypeScript compile error in ContactCard.tsx caused by an incorrect labelFormatter signature passed to Recharts Tooltip. Recharts types the label argument as ReactNode/any (not strictly number), so the callback now accepts label and safely coerces it to a timestamp when possible. If the value can’t be parsed as a valid number, it falls back to a string to avoid runtime issues while keeping the same time formatting behavior.