Skip to content

Migrate to ESLint flat config and modernize tooling #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amcdnl wants to merge 2 commits into
base: main-react-query
Choose a base branch
from
Open

Migrate to ESLint flat config and modernize tooling #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdb6951
Update all dependencies and fix breaking changes
claude Feb 24, 2026
0924a27
Update Husky pre-commit hook to v9 format
claude Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions .eslintrc.cjs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx lint-staged
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.12.0
v22.22.0
2 changes: 1 addition & 1 deletion .prettierrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"trailingComma": "none",
"arrowParens": "avoid",
"bracketSpacing": true,
"jsxBracketSameLine": false,
"bracketSameLine": false,
"printWidth": 80
}
3 changes: 0 additions & 3 deletions .storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ const config: StorybookConfig = {
'../src/**/*.story.tsx'
],
addons: [
'@storybook/addon-storysource',
'@storybook/addon-essentials',
'@storybook/addon-themes',
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of '@storybook/addon-essentials' removes several commonly used addons (actions, controls, docs, viewport, backgrounds, toolbars, measure, outline). While '@storybook/addon-docs' is explicitly added, other essential addons like actions and controls are no longer included. Verify that this is intentional and that the removed addons are not needed for the project's Storybook stories.

Suggested change
'@storybook/addon-themes',
'@storybook/addon-themes',
'@storybook/addon-essentials',

Copilot uses AI. Check for mistakes.
'@storybook/addon-interactions',
'@storybook/addon-docs',
],
framework: {
Expand Down
2 changes: 1 addition & 1 deletion .storybook/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { addons } from '@storybook/manager-api';
import { addons } from 'storybook/manager-api';
import { storybookTheme } from './theme';

addons.setConfig({
Expand Down
5 changes: 2 additions & 3 deletions .storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Preview } from '@storybook/react';
import { DocsContainer } from '@storybook/blocks';
import { Preview } from '@storybook/react-vite';
import { DocsContainer } from '@storybook/addon-docs/blocks';
import { BrowserRouter } from 'react-router';
import { ThemeProvider } from 'reablocks';

Expand All @@ -21,7 +21,6 @@ const preview: Preview = {
parameters: {
layout: 'centered',
controls: { hideNoControlsWarning: true },
actions: { argTypesRegex: '^on.*' },
docs: {
theme: storybookTheme,
container: ({ context, children }) => (
Expand Down
2 changes: 1 addition & 1 deletion .storybook/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { create } from '@storybook/theming';
import { create } from 'storybook/theming';
import Logo from '../src/assets/brand/logo.svg';

export const storybookTheme = create({
Expand Down
47 changes: 47 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
import js from '@eslint/js';
import tseslint from 'typescript-eslint';
import react from 'eslint-plugin-react';
import reactHooks from 'eslint-plugin-react-hooks';
import prettier from 'eslint-config-prettier';
import storybook from 'eslint-plugin-storybook';
import globals from 'globals';

export default tseslint.config(
{ ignores: ['dist/', 'node_modules/', 'src/core/api/queries/', 'src/core/api/requests/', '**/*.d.ts'] },
js.configs.recommended,
...tseslint.configs.recommended,
{
files: ['src/**/*.{js,ts,tsx}'],
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint configuration only targets files in 'src/**/*.{js,ts,tsx}', but there are TypeScript configuration files in the .storybook directory and root directory (like vite.config.ts, tsconfig.json) that won't be linted. Consider adding a separate configuration block to include these files, or explicitly add them to the files pattern if linting them is desired.

Suggested change
files: ['src/**/*.{js,ts,tsx}'],
files: ['src/**/*.{js,ts,tsx}', '.storybook/**/*.{js,ts,tsx}', 'vite.config.ts', 'tsconfig.json'],

Copilot uses AI. Check for mistakes.
...react.configs.flat['jsx-runtime'],
plugins: {
...react.configs.flat['jsx-runtime'].plugins,
'react-hooks': reactHooks,
},
languageOptions: {
...react.configs.flat['jsx-runtime'].languageOptions,
globals: {
...globals.browser,
},
},
settings: {
react: {
version: 'detect',
},
},
rules: {
...react.configs.flat.recommended.rules,
...react.configs.flat['jsx-runtime'].rules,
...reactHooks.configs.recommended.rules,
curly: 2,
'no-unused-vars': 'off',
'react/prop-types': 'off',
'react/display-name': 'off',
'@typescript-eslint/ban-ts-comment': 'warn',
'no-debugger': 'warn',
'@typescript-eslint/no-unused-vars': 'off',
'@typescript-eslint/no-explicit-any': 'off',
},
},
...storybook.configs['flat/recommended'],
prettier,
);
Loading