-
Notifications
You must be signed in to change notification settings - Fork 85
RELATED: FET-754 make examples work in IE11, bump dns-packet #1821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* ensure polyfills are loaded first * align the webpack config with SDK8 which is known to work
|
ok to test |
|
extended test - examples |
|
➡️ Started Live Examples deploy to: It will be destroyed on merge/close. See ci-infra and gdc-ci.yaml. |
The code coverage is the same after your change 🤟This is a good thing if you are not sure ;) Report (compared to build #8337)Covered lines: 91.99%, change: 0% Coverage report |
|
Build succeeded (check pipeline). |
|
Build succeeded (check-extended pipeline). |
|
extended test - storybook |
|
Build succeeded (check-extended pipeline). |
lupko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sonar scan result
More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-react-components-gate-PR1821 To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'. |
|
Build succeeded (gate pipeline).
|
Also bump dns-packet to 1.3.4: Closes #1820
Check PR owner responsibilities
Supported PR commands:
extended test - examplesextended test - storybookSee more options.
PR Checklist
extended test - examplesextended test - storybookRelated PRs
Related Jira tasks