Skip to content

Conversation

@no23reason
Copy link
Contributor

@no23reason no23reason commented May 27, 2021

  • ensure polyfills are loaded first
  • align the webpack config with SDK8 which is known to work

Also bump dns-packet to 1.3.4: Closes #1820


Check PR owner responsibilities

Supported PR commands:

Command Description
extended test - examples Live examples tests
extended test - storybook Storybook screenshot tests

See more options.

PR Checklist

Related PRs

  • gdc-analytical-designer:
  • gdc-dashboards:

Related Jira tasks

* ensure polyfills are loaded first
* align the webpack config with SDK8 which is known to work
@no23reason no23reason changed the base branch from develop to release May 27, 2021 09:45
@no23reason
Copy link
Contributor Author

ok to test

@no23reason
Copy link
Contributor Author

extended test - examples

@yenkins
Copy link

yenkins commented May 27, 2021

➡️ Started Live Examples deploy to:
https://gdc-live-examples-1821.herokuapp.com

It will be destroyed on merge/close. See ci-infra and gdc-ci.yaml.

@yenkins
Copy link

yenkins commented May 27, 2021

The code coverage is the same after your change 🤟

This is a good thing if you are not sure ;)

Report (compared to build #8337)

Covered lines: 91.99%, change: 0%
Covered branches: 84.04%, change: 0%

Coverage report

https://checklist.intgdc.com/job/client-libs/job/gooddata-react-components-unit-tests-zuul-docker-el7/8338/artifact/ci/results/coverage/lcov-report/index.html

@ghost
Copy link

ghost commented May 27, 2021

@ghost
Copy link

ghost commented May 27, 2021

@no23reason
Copy link
Contributor Author

extended test - storybook

@yenkins
Copy link

yenkins commented May 27, 2021

@ghost
Copy link

ghost commented May 27, 2021

@no23reason no23reason added the ready to review PR is ready to final code review label May 27, 2021
Copy link
Contributor

@lupko lupko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lupko lupko added merge and removed ready to review PR is ready to final code review labels May 27, 2021
@yenkins
Copy link

yenkins commented May 27, 2021

Sonar scan result

  • No issue found. Congratulations!

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-react-components-gate-PR1821

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label May 27, 2021
@ghost ghost merged commit f5e7d46 into gooddata:release May 27, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants