Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jun 3, 2021

No description provided.

billie-jean and others added 2 commits June 3, 2021 12:11
@ghost ghost requested review from ivan-nejezchleb, no23reason and xMort as code owners June 3, 2021 12:01
@ghost ghost added the merge label Jun 3, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

Build in pipeline check aborted.

@ghost ghost removed the merge label Jun 3, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

Merge Failed.

Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator.

@yenkins
Copy link

yenkins commented Jun 3, 2021

Sonar scan result

  • No issue found. Congratulations!

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-react-components-gate-PR1827

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@yenkins
Copy link

yenkins commented Jun 3, 2021

The code coverage is the same after your change 🤟

This is a good thing if you are not sure ;)

Report (compared to build #8351)

Covered lines: 91.99%, change: 0%
Covered branches: 84.04%, change: 0%

Coverage report

https://checklist.intgdc.com/job/client-libs/job/gooddata-react-components-unit-tests-zuul-docker-el7/8353/artifact/ci/results/coverage/lcov-report/index.html

@ghost ghost removed the merge label Jun 3, 2021
@ghost ghost merged commit 362b691 into gooddata:develop Jun 3, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants