Skip to content

RELATED: FET-793 Update screenshots for 2022 #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3 commits merged into from
Mar 1, 2022
Merged

RELATED: FET-793 Update screenshots for 2022 #1850

3 commits merged into from
Mar 1, 2022

Conversation

@pbenes
Copy link
Contributor

@pbenes pbenes commented Feb 23, 2022 •
edited
Loading

Some labels disappear due to the fact that there are more data points and highcharts
disables them as there is now less space.

Check PR owner responsibilities

Supported PR commands:

Command Description
extended test - examples Live examples tests
extended test - storybook Storybook screenshot tests

See more options.

PR Checklist

Related PRs

  • gdc-analytical-designer:
  • gdc-dashboards:

Related Jira tasks

@pbenes
Copy link
Contributor Author

pbenes commented Feb 23, 2022

extended test - storybook

@ghost
Copy link

ghost commented Feb 23, 2022

Build succeeded (check pipeline).

@yenkins
Copy link

yenkins commented Feb 23, 2022

Link to Storybook test result:

https://checklist.intgdc.com/job/client-libs/job/gooddata-react-components-storybook-zuul-docker/4427/artifact/test-storybook/html-report/index.html

@ghost
Copy link

ghost commented Feb 23, 2022

Build failed (check-extended pipeline).

@pbenes pbenes changed the title RELATED: FET-793 empty commit for tests RELATED: FET-793 Update screenshots for 2022 Feb 23, 2022
@pbenes
Copy link
Contributor Author

pbenes commented Feb 23, 2022

extended test - storybook

@ghost
Copy link

ghost commented Feb 23, 2022

Build succeeded (check pipeline).

@yenkins
Copy link

yenkins commented Feb 23, 2022

Link to Storybook test result:

https://checklist.intgdc.com/job/client-libs/job/gooddata-react-components-storybook-zuul-docker/4428/artifact/test-storybook/html-report/index.html

@ghost
Copy link

ghost commented Feb 23, 2022

Build succeeded (check-extended pipeline).

@pbenes
Copy link
Contributor Author

pbenes commented Feb 24, 2022

extended test - storybook

@yenkins
Copy link

yenkins commented Feb 24, 2022

Link to Storybook test result:

https://checklist.intgdc.com/job/client-libs/job/gooddata-react-components-storybook-zuul-docker/4429/artifact/test-storybook/html-report/index.html

@ghost
Copy link

ghost commented Feb 24, 2022

Build succeeded (check-extended pipeline).

@yenkins
Copy link

yenkins commented Feb 25, 2022

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-react-components-gate-PR1850

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Feb 25, 2022
@ghost
Copy link

ghost commented Feb 25, 2022

Build failed (gate pipeline).

@yenkins
Copy link

yenkins commented Feb 25, 2022

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-react-components-gate-PR1850

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost
Copy link

ghost commented Feb 25, 2022

Build failed (gate pipeline).

@ghost ghost removed the merge label Feb 25, 2022
@yenkins
Copy link

yenkins commented Feb 28, 2022

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-react-components-gate-PR1850

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Feb 28, 2022
@ghost
Copy link

ghost commented Feb 28, 2022

Build failed (gate pipeline).

@ghost
Copy link

ghost commented Feb 28, 2022

Build succeeded (check pipeline).

no23reason
no23reason approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@no23reason no23reason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yenkins
Copy link

yenkins commented Feb 28, 2022

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-react-components-gate-PR1850

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Feb 28, 2022
@ghost
Copy link

ghost commented Feb 28, 2022

Build failed (gate pipeline).

@pbenes
Copy link
Contributor Author

pbenes commented Feb 28, 2022

extended test - examples

@yenkins
Copy link

yenkins commented Feb 28, 2022

➡️ Started Live Examples deploy to:
https://gdc-live-examples-1850.herokuapp.com

It will be destroyed on merge/close. See ci-infra and gdc-ci.yaml.

@ghost
Copy link

ghost commented Feb 28, 2022

Build failed (check-extended pipeline).

@pbenes
Copy link
Contributor Author

pbenes commented Mar 1, 2022

extended test - examples

@yenkins
Copy link

yenkins commented Mar 1, 2022

➡️ Started Live Examples deploy to:
https://gdc-live-examples-1850.herokuapp.com

It will be destroyed on merge/close. See ci-infra and gdc-ci.yaml.

@ghost
Copy link

ghost commented Mar 1, 2022

Build succeeded (check pipeline).

@ghost
Copy link

ghost commented Mar 1, 2022

Build succeeded (check-extended pipeline).

no23reason
no23reason approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@no23reason no23reason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yenkins
Copy link

yenkins commented Mar 1, 2022

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-react-components-gate-PR1850

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Mar 1, 2022
@ghost ghost merged commit 40e8ae2 into gooddata:develop Mar 1, 2022
@ghost
Copy link

ghost commented Mar 1, 2022

Build succeeded (gate pipeline).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@no23reason no23reason no23reason approved these changes

@scavnickyj scavnickyj scavnickyj approved these changes

@ivan-nejezchleb ivan-nejezchleb Awaiting requested review from ivan-nejezchleb ivan-nejezchleb is a code owner

@xMort xMort Awaiting requested review from xMort xMort is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pbenes @yenkins @no23reason @scavnickyj