Skip to content

Conversation

@tomaso
Copy link
Contributor

@tomaso tomaso commented Nov 30, 2022

Migration from on-prem sonarqube to sonarcloud (public) instances.


Check PR owner responsibilities

Supported PR commands:

Command Description
extended test - storybook Storybook screenshot tests

See more options.

PR Checklist

Related PRs

  • gdc-analytical-designer:
  • gdc-dashboards:

Related Jira tasks

@ghost
Copy link

ghost commented Nov 30, 2022

Copy link
Contributor

@no23reason no23reason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yenkins
Copy link

yenkins commented Dec 20, 2022

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-react-components-gate-PR1865

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Dec 20, 2022
@ghost ghost merged commit 993223a into gooddata:develop Dec 20, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants