-
Notifications
You must be signed in to change notification settings - Fork 358
docs: Add failure handling guidance for agent payment flows #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: Add failure handling guidance for agent payment flows #132
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @diptendulkar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces essential documentation to standardize how agents manage and recover from various failure states within payment processing workflows. It aims to improve robustness and user experience by providing clear guidelines and examples for handling common issues like expired mandates, price changes, payment rejections, and inventory discrepancies, all while upholding user consent and mandate integrity. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds comprehensive documentation for handling failure states in agent payment flows. The new failure-handling.md document is well-structured, clear, and covers important scenarios like mandate expiration, price drift, and payment declines. The inclusion of code examples, behavior tables, and summary matrices makes it a valuable resource for developers.
My review includes a few suggestions to improve the robustness of a Python code example and to enhance the visual presentation of the flowcharts using Mermaid diagrams, which is already configured in your mkdocs.yml.
81a3597 to
e5d9dd2
Compare
Add comprehensive documentation on expected agent behavior when handling common real-world failure scenarios in payment flows. Covers: - Mandate expiration during multi-step flows - Price drift beyond mandate constraints - Payment decline / PSP rejection - Partial cart rejection (out of stock) Includes: - Detection code examples - Expected agent behavior tables - Example failure response JSON - Decision framework for mandate enforcement vs user re-prompting - Recovery action reference - Agent behavior summary matrix Addresses issue google-agentic-commerce#44: Add examples and guidance for handling failure states
e5d9dd2 to
f7bf387
Compare
Add comprehensive documentation on expected agent behavior when handling common real-world failure scenarios in payment flows.
Covers:
Includes:
References the FailureResponse types from ap2.types.errors.
Addresses issue #44 : Add examples and guidance for handling failure states
Description
Summary
Adds comprehensive documentation on expected agent behavior when handling common real-world failure scenarios in payment flows.
Addresses: #44 (Add examples and guidance for handling failure states)
What's Included
Failure Scenarios Covered
Mandate Expiration - Intent or cart expires during multi-step flow
Price Drift - Final price exceeds original quote or constraints
Payment Decline - PSP/issuer rejects the transaction
Partial Cart Rejection - Items become unavailable (out of stock, discontinued)
For Each Scenario
Additional Content
Files Changed
docs/topics/failure-handling.md- New documentationmkdocs.yml- Added to navigation and llmstxt pluginPreview
After merge, the doc will be available at:
https://ap2-protocol.org/topics/failure-handling/Related
ap2.types.errorsimports