Skip to content

Standardize Validation Fidelity: Bridge the gap between Testing and Type-checking #18529

@NTaylorMullen

Description

@NTaylorMullen

During an introspection task, it was identified that the current development workflow for Gemini CLI has a gap in 'Definition of Done' validation. Currently, npm test (via Vitest) provides fast feedback but bypasses TypeScript compilation/type-checking. This allows for aesthetic or logic changes to be 'verified' by tests while potentially harboring type-level regressions.

Key Findings:

  1. System Instruction Tension: Agents are incentivized for 'Surgical Efficiency,' which can lead to omitting full builds for 'low-risk' changes if they aren't explicitly mandated.
  2. Tooling Disconnect: npm test does not perform type-checking. npm run build is a heavy operation that often involves cross-package compilation in the monorepo.
  3. Missing 'Middle Ground': There is no targeted package-level validation command (e.g., npm run verify) that combines tsc --noEmit and vitest for surgical yet comprehensive validation.

Proposed Solutions:

  • Update GEMINI.md to explicitly mandate type-checking for all TypeScript changes.
  • Introduce an npm run verify script in each package to provide a streamlined validation path that includes type-checking.

Metadata

Metadata

Assignees

Labels

area/platformIssues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmtstatus/need-triageIssues that need to be triaged by the triage automation.🔒 maintainer only⛔ Do not contribute. Internal roadmap item.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions