-
Notifications
You must be signed in to change notification settings - Fork 13k
Fix truncation of plans in the approval dialog #20716
Copy link
Copy link
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalitystatus/need-triageIssues that need to be triaged by the triage automation.Issues that need to be triaged by the triage automation.workstream-rollupLabel used to tag epics and features that are associated with one of the three primary workstreamsLabel used to tag epics and features that are associated with one of the three primary workstreams🔒 maintainer only⛔ Do not contribute. Internal roadmap item.⛔ Do not contribute. Internal roadmap item.
Metadata
Metadata
Assignees
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalitystatus/need-triageIssues that need to be triaged by the triage automation.Issues that need to be triaged by the triage automation.workstream-rollupLabel used to tag epics and features that are associated with one of the three primary workstreamsLabel used to tag epics and features that are associated with one of the three primary workstreams🔒 maintainer only⛔ Do not contribute. Internal roadmap item.⛔ Do not contribute. Internal roadmap item.
Type
Fields
Give feedbackNo fields configured for Task.
Projects
Status
Closed
What happened?
When exiting plan mode, the plan approval dialog only shows up to 15 lines of the plan content. Any lines beyond that are hidden with a "... X lines hidden" message. For example, a 20-line plan only shows 15 lines, cutting off the last 5.
What did you expect to happen?
The full plan content should be visible (or at least use more of the available terminal height). It seems like a pretty common workflow to read the entire plan, especially with a lot of terminal real estate.
In packages/cli/src/ui/components/AskUserDialog.tsx#L792-L795, the question height for choice dialogs is hard-capped at 15 lines. Not sure if it's better to modify that (since is affects all dialogs) or something specific for plan mode.
Client information
Client Information
Run
geminito enter the interactive CLI, then run the/aboutcommand.Login information
No response
Anything else we need to know?
No response