-
Notifications
You must be signed in to change notification settings - Fork 13.5k
feat(sessions): add resuming to geminiChat and add CLI flags for session management #10719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrcabbage972
merged 30 commits into
google-gemini:main
from
Piebald-AI:add-cli-flags-for-session-mgmt
Nov 11, 2025
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
ab50e3d
feat(sessions): add resuming to geminiChat and add CLI flags for sess…
bl-ue b24c84d
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 2193087
Update packages/cli/src/utils/sessions.ts
bl-ue 1daebb4
Address bot review
bl-ue 5a702e3
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 0c9d470
Add a test argv.resume && !argv.prompt && !process.stdin.isTTY
bl-ue 5c67506
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 393377a
Setup interactive resume
bl-ue 2b40598
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 2836b66
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue d3fa6c6
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 666875d
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 9456f2a
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 4cc24a1
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue d4e0507
Extract UI resume logic to a useSessionResume hook
bl-ue ae2bfd3
Fuller deleteSession
bl-ue ee8bbe8
Bug fix
bl-ue 82c34b3
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 46a7042
Apply @jk-kashe's fix for a bug where resuming wouldn't work if authe…
bl-ue fba8c7c
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 7bb6b06
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue e01018d
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 20077cf
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 460a843
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue ee9277e
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue b1a3dc2
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 14200bd
Fix
bl-ue 5501926
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue 66d1911
Merge branch 'main' into add-cli-flags-for-session-mgmt
bl-ue b14040c
Fix new test failures from merges
bl-ue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does index number mean here? E.g. is it 1-based or 0-based? Does it start from the oldest or the newest session?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-based, starting from the oldest. So the first (oldest) session is 1, the second is 2, etc. The indices are shown in the output of
--list-sessions:At first I only implemented index-based identification. Then per @shuangliu1993's suggestion I added the ability to resume by the fixed ID as well. I thought I'd let the two methods coexist for flexibility, but I'll remove the index-based one if you think the ID is enough.