Merged
Conversation
|
Size Change: -2 B (0%) Total Size: 17.8 MB ℹ️ View Unchanged
|
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly renames waitForText to expectText and waitForExit to expectExit across the integration tests and the test helper, which improves the clarity of the test assertions. However, I found an unrelated change in one of the test files that alters a test prompt, potentially affecting its behavior. I've left a comment with a suggestion to fix it.
scidomino
force-pushed
the
tomm_refactor
branch
from
ae583fe to
c87b9ee
Compare
scidomino
force-pushed
the
tomm_refactor
branch
from
c87b9ee to
36f373d
Compare
shishu314
approved these changes
Oct 13, 2025
4 tasks
Millsondylan
pushed a commit
to Millsondylan/gemini-cli-1
that referenced
this pull request
Oct 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Rename two methods to clarify that they are asserting expectations.