feat(cli): support http and sse MCP servers in zedIntegration#12427
feat(cli): support http and sse MCP servers in zedIntegration#12427SteffenDE wants to merge 2 commits intogoogle-gemini:mainfrom SteffenDE:sd-acp-mcp
Conversation
Summary of ChangesHello @SteffenDE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for HTTP and SSE based MCP servers in the Zed integration. The changes correctly advertise the new capabilities and handle the different server configuration types during session setup. The logic is sound, but there's an opportunity to refactor duplicated code in the server configuration handling to improve maintainability and reduce redundancy.
|
Thank you @SteffenDE for this contribution. Merge conflicts appeared since you opened the PR. Can you please resolve them? Also, is there a way to directly import types from @agentclientprotocol/sdk instead of copying over the code? |
|
@michalslaski there is, I opened #13856 to use the official SDK. |
Summary
Adds support for using the ACP "Zed Integration" with SSE and HTTP based MCP servers. See https://agentclientprotocol.com/protocol/session-setup#mcp-servers.
Details
I updated the ACP schema file using the latest one from the ACP TypeScript SDK: https://github.com/agentclientprotocol/typescript-sdk/blob/main/src/schema.ts
How to Validate
Since Zed doesn't support non-stdio MCPs, I tested this using tidewave.ai's upcoming ACP integration. You could also manually send JSON-RPC messages over stdio to verify, but without #10089, testing in the terminal doesn't really work.
Pre-Merge Checklist