remove duplicated mouse code

[scidomino]

Summary

Remove code for enabling mouse mode that is already present in mouse.ts.

Related Issues

Follow up for #13478

How to Validate

Verify that the mouse still works.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @scidomino, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring the terminal protocol detection logic by removing redundant code related to the SGR mouse protocol. The change streamlines the kittyProtocolDetector module, ensuring that only the necessary Kitty keyboard protocol handling remains. This simplification reduces complexity and improves the clarity of how terminal protocols are managed within the application.

Highlights

• Removed SGR Mouse Protocol Support: The code responsible for detecting, enabling, and disabling the SGR (Select Graphic Rendition) mouse protocol has been entirely removed from the kittyProtocolDetector.ts file.
• Streamlined Protocol Activation: The logic for activating supported protocols now exclusively checks for kittySupported, simplifying the conditional flow and removing the redundant check for sgrMouseSupported.
• Code Cleanup: Unused variables sgrMouseSupported and sgrMouseEnabled have been deleted, contributing to a cleaner and more maintainable codebase.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: -358 B (0%)

Total Size: 21.1 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	21.1 MB	-358 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request removes code related to SGR mouse mode detection and enablement from the Kitty protocol detector. The stated goal is to remove duplicated code. However, this change appears to remove mouse support for all non-Kitty-compatible terminals, which would be a significant regression for users on terminals like iTerm2 or Windows Terminal. My review includes a comment highlighting this potential issue and requesting clarification.

[jacob314]