Conversation
Summary of ChangesHello @jacob314, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the application's standard I/O handling by relocating core terminal interaction utilities from the CLI package to the shared core library. This change centralizes common I/O functionalities, making them accessible to other parts of the application that require direct terminal writes. Additionally, a temporary debugging adjustment has been included to facilitate troubleshooting of an authentication-related issue. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…rce writes directly to the terminal
There was a problem hiding this comment.
Code Review
This pull request successfully moves the stdio utilities to the @google/gemini-cli-core package, which is a good refactoring to allow core components to access them. The changes across the CLI package to update imports and mocks are consistent with this move. However, there is a critical issue in packages/core/src/config/config.ts where a temporary hack has been introduced that disables browser-based authentication. This must be reverted before merging.
|
Size Change: +352 B (0%) Total Size: 21.1 MB ℹ️ View Unchanged
|
Uh oh!
There was an error while loading. Please reload this page.