Skip to content

move stdio#13528

Merged
jacob314 merged 2 commits intomainfrom
move_stdio
Nov 20, 2025
Merged

move stdio#13528
jacob314 merged 2 commits intomainfrom
move_stdio

Conversation

@jacob314
Copy link
Copy Markdown
Contributor

@jacob314 jacob314 commented Nov 20, 2025

  • Move stdio.ts to core as there are a few places in core we need to force writes directly to the terminal when core needs to render semi interactive UI to enter auth codes.

@jacob314 jacob314 requested a review from a team as a code owner November 20, 2025 19:47
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jacob314, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the application's standard I/O handling by relocating core terminal interaction utilities from the CLI package to the shared core library. This change centralizes common I/O functionalities, making them accessible to other parts of the application that require direct terminal writes. Additionally, a temporary debugging adjustment has been included to facilitate troubleshooting of an authentication-related issue.

Highlights

  • Refactored Standard I/O Utilities: The stdio.ts and stdio.test.ts files have been moved from packages/cli/src/utils to packages/core/src/utils.
  • Centralized Stdio Access: Stdio utility functions (writeToStdout, patchStdio, createInkStdio, writeToStderr) are now exported from @google/gemini-cli-core, allowing core components to directly manage terminal output.
  • Temporary Debugging Change: A temporary modification was made in packages/core/src/config/config.ts to suppress browser launches, likely for debugging an authentication issue.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully moves the stdio utilities to the @google/gemini-cli-core package, which is a good refactoring to allow core components to access them. The changes across the CLI package to update imports and mocks are consistent with this move. However, there is a critical issue in packages/core/src/config/config.ts where a temporary hack has been introduced that disables browser-based authentication. This must be reverted before merging.

@jacob314 jacob314 enabled auto-merge November 20, 2025 19:50
@jacob314 jacob314 requested a review from scidomino November 20, 2025 19:50
@github-actions
Copy link
Copy Markdown

Size Change: +352 B (0%)

Total Size: 21.1 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 21.1 MB +352 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@jacob314 jacob314 added this pull request to the merge queue Nov 20, 2025
Merged via the queue into main with commit fec0eba Nov 20, 2025
22 checks passed
@jacob314 jacob314 deleted the move_stdio branch November 20, 2025 22:28
thacio added a commit to thacio/auditaria that referenced this pull request Nov 23, 2025
werdnum pushed a commit to werdnum/gemini-cli that referenced this pull request Nov 24, 2025
mboshernitsan pushed a commit that referenced this pull request Nov 25, 2025
SandyTao520 pushed a commit that referenced this pull request Nov 26, 2025
danpalmer pushed a commit to danpalmer/gemini-cli that referenced this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants