Remove useModelRouter experimental flag

[Adib234]

Summary

Removes a flag

Details

This flag confuses users because when it is set off, it disables future model selection via /model

Related Issues

Fixes #13472

How to Validate

Checked to see if useModelRouter setting still existed in the settings dialog and made sure that /model still worked

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @Adib234, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on simplifying the model selection process within the CLI by eliminating the experimental useModelRouter flag. This flag was identified as a source of confusion for users and, when disabled, inadvertently prevented the use of the /model command for future model selections. By removing this flag and its associated conditional logic, the PR aims to provide a more straightforward and consistent experience for users when interacting with models, ensuring that model selection via /model is always available and predictable.

Highlights

• Removal of useModelRouter Flag: The experimental useModelRouter configuration flag has been entirely removed from the codebase, simplifying the CLI's configuration.
• Simplified Model Selection Logic: The logic for determining the default model has been streamlined, now consistently defaulting to auto without conditional checks based on the removed flag.
• Documentation Updates: All references to the useModelRouter flag have been removed from the CLI documentation, including configuration guides and model routing explanations.
• Test Suite Refinement: Numerous unit tests related to the useModelRouter flag, its default behavior, and its interaction with model selection precedence, have been removed.
• Consistent /model Command Behavior: The change ensures that the /model command for model selection is always enabled, resolving a previous issue where disabling the flag would prevent its use.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request cleanly removes the useModelRouter experimental flag, simplifying the configuration and making the model router behavior the default. The changes are comprehensive, touching documentation, configuration schemas, application logic, and tests. All related code paths have been updated consistently, and the removal of the flag and its associated logic is well-executed. The code quality is high, and the PR successfully achieves its goal.

[github-actions]

Size Change: -1.15 kB (-0.01%)

Total Size: 21.1 MB

Filename	Size	Change
./bundle/gemini.js	21.1 MB	-1.15 kB (-0.01%)

ℹ️ View Unchanged

Filename	Size
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB
./bundle/sandbox-macos-permissive-open.sb	890 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB

_{compressed-size-action}