Add license field into package.json#14473
Conversation
Add the license field in the package.json to reflect the project license.
Summary of ChangesHello @jb-perez, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds the license field to the root package.json. However, it overlooks adding the same field to the public, publishable packages within the monorepo's packages directory. I've added a comment with details on which packages need to be updated to fully address license declaration for the project.
| { | ||
| "name": "@google/gemini-cli", | ||
| "version": "0.21.0-nightly.20251202.2d935b379", | ||
| "license": "Apache-2.0", |
There was a problem hiding this comment.
Adding the license to the root package.json is a good first step. However, this package is marked as private (via "private": "true") and is not published. The public packages that are distributed to users are still missing their license information. To properly declare the project's license, please add "license": "Apache-2.0" to the package.json of each public package in the packages/ directory, specifically for @google/gemini-cli, @google/gemini-cli-core, and @google/gemini-cli-a2a-server.
Add the license field in the package.json to reflect the project license.
Summary
Add the license information into the package.json to reflect the project license.
Details
License field is used by different systems to quickly identify the project license.
How to Validate
Verify license property is present.
Pre-Merge Checklist