Skip to content

fix: use Gemini API supported image formats for clipboard#14762

Merged
jackwotherspoon merged 4 commits intomainfrom
fix-image-formats
Dec 9, 2025
Merged

fix: use Gemini API supported image formats for clipboard#14762
jackwotherspoon merged 4 commits intomainfrom
fix-image-formats

Conversation

@jackwotherspoon
Copy link
Copy Markdown
Collaborator

@jackwotherspoon jackwotherspoon commented Dec 9, 2025

Summary

Updates clipboard image handling to only use formats supported by the Gemini API.

Changes:

  • Remove TIFF and GIF from clipboard save formats (not supported by Gemini API)
  • Export IMAGE_EXTENSIONS constant for reuse across clipboard utilities
  • Refactor cleanupOldClipboardImages to use the shared constant

Supported formats: PNG, JPEG, WEBP, HEIC, HEIF

Reference: https://ai.google.dev/gemini-api/docs/image-understanding#supported-formats

Related Issues

Part 1 of breaking up #14706 into smaller chunks

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@jackwotherspoon jackwotherspoon requested a review from a team as a code owner December 9, 2025 03:03
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jackwotherspoon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the application's clipboard image handling to strictly adhere to the image formats supported by the Gemini API. By removing unsupported formats and centralizing the definition of acceptable extensions, the change aims to prevent potential compatibility issues and streamline image processing for API interactions.

Highlights

  • Clipboard Image Format Restriction: Removed TIFF and GIF from the list of image formats saved from the clipboard, as these are not supported by the Gemini API.
  • New Constant for Image Extensions: Introduced and exported an IMAGE_EXTENSIONS constant, listing all image formats supported by the Gemini API (PNG, JPEG, WEBP, HEIC, HEIF), for consistent reuse across clipboard utilities.
  • Refactored Cleanup Utility: Updated the cleanupOldClipboardImages function to utilize the newly defined IMAGE_EXTENSIONS constant, ensuring that only relevant image files are considered for cleanup.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates clipboard image handling to align with formats supported by the Gemini API. The changes correctly remove unsupported formats (TIFF, GIF) and refactor the cleanup logic to use a new shared constant for image extensions. My review highlights two main points: a misleading comment in saveClipboardImage that lists formats not actually handled, and a change in cleanupOldClipboardImages that stops it from cleaning up legacy format files, which could lead to orphaned files.

Comment thread packages/cli/src/ui/utils/clipboardUtils.ts Outdated
Comment thread packages/cli/src/ui/utils/clipboardUtils.ts
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025

Size Change: -11 B (0%)

Total Size: 21.6 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 21.5 MB -11 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@scidomino scidomino enabled auto-merge December 9, 2025 03:57
@scidomino scidomino added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@jackwotherspoon jackwotherspoon added this pull request to the merge queue Dec 9, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@jackwotherspoon jackwotherspoon added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit afd4829 Dec 9, 2025
20 checks passed
@jackwotherspoon jackwotherspoon deleted the fix-image-formats branch December 9, 2025 12:42
thacio added a commit to thacio/auditaria that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants