Skip to content

feat: reset availabilityService on /auth#14911

Merged
adamfweidman merged 1 commit intomainfrom
afw/auth-avail-reset
Dec 10, 2025
Merged

feat: reset availabilityService on /auth#14911
adamfweidman merged 1 commit intomainfrom
afw/auth-avail-reset

Conversation

@adamfweidman
Copy link
Copy Markdown
Contributor

Summary

Reset availabilityService when user selects /auth

Related Issues

Fixes: https://github.com/google-gemini/maintainers-gemini-cli/issues/1133

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@adamfweidman adamfweidman requested a review from a team as a code owner December 10, 2025 20:04
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @adamfweidman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where model availability status might become stale after an authentication change. By introducing a mechanism to reset the ModelAvailabilityService whenever the authentication method is refreshed, the system can now ensure that it always operates with current and accurate model health information, thereby improving reliability and preventing potential issues related to outdated service states.

Highlights

  • Model Availability Service Reset: A new reset() method has been added to the ModelAvailabilityService to clear its internal health state, ensuring that model availability data can be refreshed.
  • Authentication Refresh Integration: The refreshAuth method in the Config class now calls the modelAvailabilityService.reset() method at the beginning of its execution. This ensures that model availability status is cleared whenever the authentication method is changed or refreshed.
  • New Test Coverage: A new test case has been added to config.test.ts to verify that the modelAvailabilityService.reset() method is correctly invoked when config.refreshAuth() is called.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to reset the model availability service when the authentication method is changed. This correctly handles scenarios where model availability (e.g., due to quotas) might differ between authentication contexts. The implementation is clean and simple, adding a reset() method to ModelAvailabilityService and invoking it within refreshAuth. The change is well-supported by a new unit test that verifies the reset logic is triggered as expected. Overall, this is a good improvement for the application's robustness.

Comment thread packages/core/src/availability/modelAvailabilityService.ts
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 10, 2025

Size Change: +145 B (0%)

Total Size: 21.6 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 21.6 MB +145 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Copy link
Copy Markdown
Contributor

@sehoon38 sehoon38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamfweidman adamfweidman added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit 8c83e1e Dec 10, 2025
20 checks passed
@adamfweidman adamfweidman deleted the afw/auth-avail-reset branch December 10, 2025 22:07
psinha40898 pushed a commit to psinha40898/gemini-cli that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants