Refresh hooks when refreshing extensions.

[scidomino]

Summary

Refresh hooks when refreshing extensions

Details

Also:

• removed unnecessary initialization protection from hooks. HookSystem.initialize() is only called from config.initialize() which already has protections against multiple calls.
• removed .integration-test file that was accidentally merged in a previous PR.

Related Issues

Fixes #14531

How to Validate

Uninstall an extension with a hook and verify that it no longer gets called.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @scidomino, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability to dynamically reload extension hooks without requiring a full application restart. By adding explicit refresh mechanisms to the hook registry and system, and integrating these into the extension loading process, the system can now seamlessly update its understanding of available hooks when extensions are installed, uninstalled, or updated. This significantly improves the developer and user experience by making extension changes immediately effective.

Highlights

• Hook Registry Refresh: Introduced a refresh method in HookRegistry to clear and re-process all registered hooks from the configuration, allowing for dynamic updates.
• Hook System Integration: Added a refresh method to HookSystem that orchestrates the reloading of the hook registry.
• Extension Reloading: Integrated the hook system refresh into the ExtensionLoader, ensuring hooks are reloaded whenever extensions are loaded or unloaded, provided extension reloading is enabled.
• Integration Test: A new integration test hooks-reload.test.ts was added to verify that updating an extension correctly reloads its associated hooks, demonstrating the functionality end-to-end.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: -993 B (0%)

Total Size: 21.6 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	21.6 MB	-993 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request introduces the ability to refresh hooks when an extension is updated, which is a valuable enhancement. The implementation involves adding a refresh method to the hook system and integrating it into the extension loading lifecycle. A new integration test validates this new functionality. My review focuses on two areas for improvement: enhancing the reliability of the new integration test by removing a fixed delay, and addressing code duplication in the HookRegistry to improve long-term maintainability.

[scidomino]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly implements the reloading of hooks when extensions are refreshed by re-initializing the hook system. The removal of redundant initialization checks in HookSystem and HookRegistry simplifies the code and enables this re-initialization. The changes are well-tested with a new integration test and updates to existing unit tests. I've found one critical issue in the new integration test regarding shell command quoting that could make the test flaky or fail in certain environments.

[scidomino]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly implements the refreshing of hooks when extensions are updated. The core change in extensionLoader.ts to re-initialize the hook system is sound and is triggered correctly after extension loading or unloading operations. The related refactoring to remove idempotency checks in the hook system's initialization is a necessary and clean way to enable this refresh behavior. The addition of a comprehensive integration test (hooks-reload.test.ts) is excellent, as it thoroughly validates the end-to-end functionality. The changes are well-implemented and improve the extension ecosystem.