chore/release: bump version to 0.21.0-nightly.20251212.54de67536#14969
chore/release: bump version to 0.21.0-nightly.20251212.54de67536#14969
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an automated version bump for the Gemini CLI project, incrementing the version number for a nightly release across the main project and all its sub-packages. This ensures that all components, including the sandbox image URI, are aligned with the latest development build. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: -2 B (0%) Total Size: 21.6 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request performs an automated version bump to "0.21.0-nightly.20251212.54de67536", with version updates appearing consistent across package.json files and package-lock.json. However, a critical command injection vulnerability was identified in the scripts/version.js file. This vulnerability stems from the script's failure to sanitize user-provided command-line arguments, which could lead to arbitrary code execution. Additionally, suggestions have been provided to enhance the robustness of the scripts/version.js automation for future releases, which do not block this PR.
| { | ||
| "name": "@google/gemini-cli", | ||
| "version": "0.21.0-nightly.20251211.8c83e1ea9", | ||
| "version": "0.21.0-nightly.20251212.54de67536", |
There was a problem hiding this comment.
The version bump is correct. However, reviewing the scripts/version.js script that automates this process, I found two areas for improvement to make the release process more robust and maintainable:
- Incomplete lockfile update: The script runs
npm install --workspace packages/cli --workspace packages/core --package-lock-only. This only considers a subset of workspaces and could lead to an inconsistentpackage-lock.jsonin the future. It should probably benpm install --package-lock-onlyto cover all workspaces. - Hardcoded paths for
sandboxImageUri: The script hardcodes the paths topackage.jsonandpackages/cli/package.jsonto updatesandboxImageUri. This should be made dynamic to automatically handle new packages.
…ly.20251212.54de67536 (google-gemini#14969)
Automated version bump for nightly release.