Skip to content

bug(core): Fix bug when saving plans.#18465

Merged
jerop merged 2 commits intomainfrom
jl/fix-plan
Feb 6, 2026
Merged

bug(core): Fix bug when saving plans.#18465
jerop merged 2 commits intomainfrom
jl/fix-plan

Conversation

@joshualitt
Copy link
Copy Markdown
Contributor

@joshualitt joshualitt commented Feb 6, 2026

Closes #18467

@joshualitt joshualitt requested a review from jerop February 6, 2026 20:13
@joshualitt joshualitt marked this pull request as ready for review February 6, 2026 20:14
@joshualitt joshualitt requested a review from a team as a code owner February 6, 2026 20:14
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @joshualitt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug encountered when saving plans by refining the file path validation logic. The change updates a regular expression in the core policy configuration, ensuring that temporary plan files can be correctly identified and processed, thereby resolving issues related to plan saving operations.

Highlights

  • Policy Update: The regular expression for argsPattern within the plan.toml policy file has been updated. Specifically, the pattern matching the temporary directory name in file paths has been broadened from a fixed 64-character hexadecimal string to any sequence of one or more alphanumeric characters.
Changelog
  • packages/core/src/policy/policies/plan.toml
    • Updated the argsPattern regular expression to correctly match temporary directory names in file paths, changing [a-f0-9]{64} to [a-zA-Z0-9]+.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli Bot commented Feb 6, 2026

Hi @joshualitt, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli Bot commented Feb 6, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli Bot closed this Feb 6, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a regular expression in a policy file to fix a bug related to saving plans. The change correctly identifies that the temporary directory name is not always a 64-character hex string and broadens the matching pattern. I've suggested a small improvement to make the new pattern even more robust by allowing for hyphens and underscores, which would align it with conventions seen elsewhere in the codebase for sanitized path components.

Comment thread packages/core/src/policy/policies/plan.toml Outdated
@joshualitt joshualitt reopened this Feb 6, 2026
@jerop jerop enabled auto-merge February 6, 2026 20:21
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 6, 2026

Size Change: -2 B (0%)

Total Size: 23.8 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.8 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-cli gemini-cli Bot added area/core Issues related to User Interface, OS Support, Core Functionality area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality area/enterprise Issues related to Telemetry, Policy, Quota / Licensing 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. labels Feb 6, 2026
@jerop jerop added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 7a8d6f6 Feb 6, 2026
26 checks passed
@jerop jerop deleted the jl/fix-plan branch February 6, 2026 20:53
aswinashok44 pushed a commit to aswinashok44/gemini-cli that referenced this pull request Feb 9, 2026
kuishou68 pushed a commit to iOfficeAI/aioncli that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality area/core Issues related to User Interface, OS Support, Core Functionality area/enterprise Issues related to Telemetry, Policy, Quota / Licensing 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix plan storage path given changes in tmp dir

2 participants