bug(core): Ensure storage is initialized early, even if config is not.#18471
bug(core): Ensure storage is initialized early, even if config is not.#18471joshualitt merged 1 commit intomainfrom
Conversation
|
Hi @joshualitt, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @joshualitt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical bug where the application's storage mechanism was not always initialized in time for operations that depend on it, particularly when resuming user sessions. By relocating the storage initialization call to an earlier stage in the application's startup sequence, this change guarantees that storage is ready and accessible, thereby preventing "Storage must be initialized before use" errors and improving the reliability of session management. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a critical bug where storage was not initialized early enough, leading to errors when using features like session resumption. The fix correctly introduces an explicit storage initialization step immediately after the configuration is loaded. This ensures that all subsequent operations that depend on storage, such as listing or resuming sessions, can function as expected. A new integration test is also added, which effectively reproduces the original issue and confirms that the fix resolves it. The changes are well-implemented and improve the robustness of the CLI.
|
Size Change: +38 B (0%) Total Size: 23.8 MB ℹ️ View Unchanged
|
aebf9ac to
f46cca0
Compare

No description provided.