Skip to content

bug(core): Ensure storage is initialized early, even if config is not.#18471

Merged
joshualitt merged 1 commit intomainfrom
jl/fix-resume
Feb 6, 2026
Merged

bug(core): Ensure storage is initialized early, even if config is not.#18471
joshualitt merged 1 commit intomainfrom
jl/fix-resume

Conversation

@joshualitt
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli Bot commented Feb 6, 2026

Hi @joshualitt, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli Bot commented Feb 6, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @joshualitt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug where the application's storage mechanism was not always initialized in time for operations that depend on it, particularly when resuming user sessions. By relocating the storage initialization call to an earlier stage in the application's startup sequence, this change guarantees that storage is ready and accessible, thereby preventing "Storage must be initialized before use" errors and improving the reliability of session management.

Highlights

  • Storage Initialization Timing: The config.storage.initialize() call in packages/cli/src/gemini.tsx has been moved to an earlier point in the application's startup sequence, ensuring storage is initialized immediately after configuration loading.
  • New Integration Test for Session Resume: A new integration test, integration-tests/resume_repro.test.ts, has been added to specifically reproduce and verify the fix for a bug where resuming a session could fail due to uninitialized storage.
  • Mock Response File: A new mock response file, integration-tests/resume_repro.responses, was added to support the newly introduced integration test.
Changelog
  • integration-tests/resume_repro.responses
    • Added a new file containing a JSON mock response for the generateContentStream method, used by the new integration test.
  • integration-tests/resume_repro.test.ts
    • Added a new integration test file to specifically test the scenario of resuming a session.
    • The test verifies that a session can be resumed successfully without encountering storage initialization errors.
  • packages/cli/src/gemini.tsx
    • Relocated the await config.storage.initialize() call to execute immediately after the configuration loading is complete (loadConfigHandle?.end()). This ensures that storage is initialized before any subsequent operations that might rely on it, such as session resumption.
Activity
  • No human activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-cli gemini-cli Bot closed this Feb 6, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a critical bug where storage was not initialized early enough, leading to errors when using features like session resumption. The fix correctly introduces an explicit storage initialization step immediately after the configuration is loaded. This ensures that all subsequent operations that depend on storage, such as listing or resuming sessions, can function as expected. A new integration test is also added, which effectively reproduces the original issue and confirms that the fix resolves it. The changes are well-implemented and improve the robustness of the CLI.

@joshualitt joshualitt reopened this Feb 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 6, 2026

Size Change: +38 B (0%)

Total Size: 23.8 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.8 MB +38 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@joshualitt joshualitt marked this pull request as ready for review February 6, 2026 20:54
@joshualitt joshualitt requested a review from a team as a code owner February 6, 2026 20:54
@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 6, 2026
Copy link
Copy Markdown
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshualitt joshualitt added this pull request to the merge queue Feb 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 6, 2026
@joshualitt joshualitt added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit fd72a8c Feb 6, 2026
26 checks passed
@joshualitt joshualitt deleted the jl/fix-resume branch February 6, 2026 21:54
aswinashok44 pushed a commit to aswinashok44/gemini-cli that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants