feat(plan): add integration tests for plan mode

[Adib234]

Summary

Adds integration tests for plan mode.

Details

Following integration tests were added

• allowing read-only tools and rejecting write tools
• verifying that write_file only writes to the designated plans directory
• enters plan mode when user prompts successfully

exit_plan_mode tool integration tests were too flakey to test and harder to set assertions (e.g. sometimes the model would ask questions before exiting)

Related Issues

Fixes #19674

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @Adib234, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive suite of integration tests specifically designed for the 'plan' mode. These tests are crucial for validating the intended behavior and security constraints of plan mode, ensuring that tool usage is correctly restricted and that the system transitions into plan mode as expected. The addition of these tests significantly enhances the robustness and reliability of the plan mode feature.

Highlights

• New Integration Tests for Plan Mode: Added a new test file dedicated to integration tests for the 'plan' mode functionality.
• Read-Only vs. Write Tool Restrictions: Implemented a test to verify that read-only tools are permitted while write tools are denied when operating in plan mode.
• Write File Directory Restrictions: Included a test to ensure that the write_file tool can only write to the designated 'plans' directory, blocking attempts to write elsewhere.
• Entering Plan Mode: Added a test case to confirm that the system can successfully transition into plan mode when prompted by the user.

Changelog

• integration-tests/plan-mode.test.ts
  • Added new integration tests for plan mode functionality.
  • Verified read-only tool allowance and write tool denial in plan mode.
  • Confirmed write_file tool restrictions to the 'plans' directory.
  • Ensured successful entry into plan mode from default mode.

Activity

• The pull request was opened by Adib234.
• No additional human activity (comments, reviews) has been recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: -2 B (0%)

Total Size: 25.7 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	25.2 MB	-2 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js	221 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js	227 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js	11.5 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js	132 B	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request adds valuable integration tests for the plan mode feature. The tests cover allowing read-only tools, restricting write tools, and entering plan mode via natural language.

[jerop]

how do we confirm that it's only in plans directory? should have something showing tool denial outside of plans dir?